fix(secrets): suppress unhandled stdout/stderr stream errors in exec resolver#100419
Closed
cxbAsDev wants to merge 1 commit into
Closed
fix(secrets): suppress unhandled stdout/stderr stream errors in exec resolver#100419cxbAsDev wants to merge 1 commit into
cxbAsDev wants to merge 1 commit into
Conversation
openclaw-barnacle
Bot
added
size: S
r: too-many-prs
|
Closing this PR because the author has more than 20 active PRs in this repo. Please reduce the active PR queue and reopen or resubmit once it is back under the limit. You can close your own PRs to get back under the limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
runExecResolverattachesdatalisteners tochild.stdoutandchild.stderr, but does not attacherrorlisteners. If either stream emits anerrorevent, the unhandled error can crash the OpenClaw process during secret resolution.Why This Change Was Made
Add no-op
errorhandlers to both stdout and stderr streams before the data handlers, mirroring the existing stdin error handling pattern. This prevents unhandled stream errors from propagating as uncaught exceptions.User Impact
More robust exec-based secret resolution: transient stream read errors no longer crash the process.
Evidence
src/secrets/resolve.test.tsthat mocksspawn, emitserrorevents on both stdout and stderr, and verifiesresolveSecretRefStringstill resolves successfully.main(times out with an unhandledError: stdout read failed) and passes with this fix.oxlintpasses on the changed files.