fix(ci): bound hosted gate workflow pagination#100332
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 5, 2026, 11:48 AM ET / 15:48 UTC. Summary PR surface: Tests +9, Other +26. Total +35 across 2 files. Reproducibility: no. live quota exhaustion was reproduced in this read-only review. Source inspection shows current main asks Review metrics: 1 noteworthy metric.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the bounded pagination fix through normal maintainer gates once current-head required checks and prepare-run evidence are acceptable, keeping hosted gate evidence centralized in Do we have a high-confidence way to reproduce the issue? No live quota exhaustion was reproduced in this read-only review. Source inspection shows current main asks Is this the best way to solve the issue? Yes. The PR fixes the narrow owner path by replacing the verifier's unbounded page walker, while leaving the downstream exact-head evidence selection unchanged and covered by focused tests. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against a308e3b83429. Label changesLabel justifications:
Evidence reviewedPR surface: Tests +9, Other +26. Total +35 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (3 earlier review cycles) |
|
Land-ready at Proof:
No known proof gaps. Internal CI/landing tooling only; no changelog required. |
0665349 to
604790f
Compare
|
Rebased land-ready proof for exact head
No remaining proof gaps. Proceeding through the repository landing wrapper. |
604790f to
c6d19b3
Compare
|
Final exact-head refresh: |
c6d19b3 to
ff3e1bf
Compare
|
Exact-head CI retry is green for Attempt 1 had one QA timing failure in unrelated |
ff3e1bf to
6ef1068
Compare
|
Exact-head hosted proof is green on
The repo-native review artifacts validate for this exact PR head; ready for the merge wrapper. |
|
Merged via squash.
|
What Problem This Solves
Fixes an issue where maintainers landing a pull request could exhaust the shared GitHub REST API quota when the hosted-gate verifier followed an unbounded workflow-runs pagination chain.
Why This Change Was Made
The verifier now fetches workflow-run pages explicitly, repeating the exact head SHA on every request and stopping at GitHub's documented 1,000-result search window. This preserves complete gate evidence while bounding API use.
User Impact
No product behavior changes. Maintainer PR preparation remains complete and no longer risks consuming an hourly API quota in one run.
Evidence
tbx_01kws6dks482rv1pbv7erbnvkp:pnpm test test/scripts/verify-pr-hosted-gates.test.ts— 18/18 passed.pnpm check:changed— tooling lane passed.head_sha, a maximum page size of 100, and a 1,000-result search cap: https://docs.github.com/en/rest/actions/workflow-runs#list-workflow-runs-for-a-repository