-
-
Notifications
You must be signed in to change notification settings - Fork 80.7k
Improve agent runtime correctness from upstream Pi audit #99924
Copy link
Copy link
Closed
Labels
P0Emergency: data loss, security bypass, crash loop, or unusable core runtime.Emergency: data loss, security bypass, crash loop, or unusable core runtime.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:needs-live-reproClawSweeper needs live local, crabbox, or manual validation to confirm this issue.ClawSweeper needs live local, crabbox, or manual validation to confirm this issue.clawsweeper:needs-maintainer-reviewClawSweeper marked this issue as needing maintainer review before automation.ClawSweeper marked this issue as needing maintainer review before automation.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.enhancementNew feature or requestNew feature or requestimpact:auth-providerAuth, provider routing, model choice, or SecretRef resolution may break.Auth, provider routing, model choice, or SecretRef resolution may break.impact:data-lossCan lose, corrupt, or silently drop user/session/config data.Can lose, corrupt, or silently drop user/session/config data.impact:session-stateSession, memory, transcript, context, or agent state can drift or corrupt.Session, memory, transcript, context, or agent state can drift or corrupt.issue-rating: 🐚 platinum hermitGood issue quality with a plausible reproduction path needing some confirmation.Good issue quality with a plausible reproduction path needing some confirmation.maintainerMaintainer-authored PRMaintainer-authored PR
Description
Metadata
Metadata
Assignees
Labels
P0Emergency: data loss, security bypass, crash loop, or unusable core runtime.Emergency: data loss, security bypass, crash loop, or unusable core runtime.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:needs-live-reproClawSweeper needs live local, crabbox, or manual validation to confirm this issue.ClawSweeper needs live local, crabbox, or manual validation to confirm this issue.clawsweeper:needs-maintainer-reviewClawSweeper marked this issue as needing maintainer review before automation.ClawSweeper marked this issue as needing maintainer review before automation.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.enhancementNew feature or requestNew feature or requestimpact:auth-providerAuth, provider routing, model choice, or SecretRef resolution may break.Auth, provider routing, model choice, or SecretRef resolution may break.impact:data-lossCan lose, corrupt, or silently drop user/session/config data.Can lose, corrupt, or silently drop user/session/config data.impact:session-stateSession, memory, transcript, context, or agent state can drift or corrupt.Session, memory, transcript, context, or agent state can drift or corrupt.issue-rating: 🐚 platinum hermitGood issue quality with a plausible reproduction path needing some confirmation.Good issue quality with a plausible reproduction path needing some confirmation.maintainerMaintainer-authored PRMaintainer-authored PR
Type
Fields
Priority
None yet
Summary
Adopt the current, proven runtime correctness improvements from the upstream Pi agent stack where OpenClaw still carries equivalent older behavior.
Problem to solve
An audit against
earendil-works/piv0.80.3 and current main found several user-visible correctness gaps in OpenClaw's inherited or parallel runtime surfaces: fuzzy edits can rewrite untouched whitespace, model-added edit metadata fails validation, nested-repository find behavior can ignore the wrong rules, descendant process output can be truncated, late tool progress can leak after completion, compaction summaries can race, provider overflow and retry wording can be missed, ChatGPT transport reuse can exceed backend limits, and BMP reads are not normalized for model input.The root TUI dependency also trails two minor releases containing upstream rendering and input fixes.
Proposed solution
Port the bounded upstream fixes into the existing OpenClaw owner boundaries, retaining OpenClaw's strict provider schemas and shared media/runtime abstractions. Add focused regression tests for every changed behavior, upgrade
@earendil-works/pi-tuito the current stable release, and validate the aggregate through targeted tests, remote changed gates, a package build, and a live OpenAI/Codex agent scenario.Non-goals: importing Pi's model registry, orchestrator, RPC shell, or project-trust architecture; replacing OpenClaw's existing unified/multi-edit support; adding compatibility shims or new config.
Alternatives considered
Impact
Evidence/examples
reasonfield.fd --no-require-gitbehavior fails to re-enable nested-repository ignore rules.Additional information
This is maintainer-directed implementation work. No public config, protocol, or storage shape changes are planned.