-
-
Notifications
You must be signed in to change notification settings - Fork 80.7k
fix(matrix): THINKING_TAG_RE missing mm: namespace prefix in monitor replies #99412
Copy link
Copy link
Open
Labels
P1High-priority user-facing bug, regression, or broken workflow.High-priority user-facing bug, regression, or broken workflow.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:needs-security-reviewClawSweeper marked this issue as needing security-sensitive review.ClawSweeper marked this issue as needing security-sensitive review.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:securitySecurity boundary, credential, authz, sandbox, or sensitive-data risk.Security boundary, credential, authz, sandbox, or sensitive-data risk.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.
Description
Metadata
Metadata
Assignees
Labels
P1High-priority user-facing bug, regression, or broken workflow.High-priority user-facing bug, regression, or broken workflow.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:needs-security-reviewClawSweeper marked this issue as needing security-sensitive review.ClawSweeper marked this issue as needing security-sensitive review.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:securitySecurity boundary, credential, authz, sandbox, or sensitive-data risk.Security boundary, credential, authz, sandbox, or sensitive-data risk.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.
Type
Fields
Priority
None yet
Problem
The
THINKING_TAG_REandTHINKING_BLOCK_REregex patterns inextensions/matrix/src/matrix/monitor/replies.tsare missing themm:namespace prefix for detecting MiniMax reasoning tags.Context
PR #93767 fixed the core
reasoning-tags.ts, and PRs #93806/#93820 fixed additional missed locations (silent-reply, streaming, iMessage paths). However, the Matrix monitor'sreplies.tswas also missed.The regex currently matches
antml:namespaced tags but notmm:namespaced tags:Impact
MiniMax model
mm:thinkreasoning content is not recognized as reasoning-only byshouldSuppressReasoningReplyText(), causing raw reasoning tags to leak into Matrix room messages.Fix
Add
(?:antml:|mm:)?prefix tothink(?:ing)?andthoughtin bothTHINKING_TAG_REandTHINKING_BLOCK_RE, consistent with the pattern applied in the 6 already-fixed files.