-
-
Notifications
You must be signed in to change notification settings - Fork 80.7k
[Feature]: Rename Codex destructive approval policy to ask #98499
Copy link
Copy link
Closed
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:needs-security-reviewClawSweeper marked this issue as needing security-sensitive review.ClawSweeper marked this issue as needing security-sensitive review.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.enhancementNew feature or requestNew feature or requestimpact:securitySecurity boundary, credential, authz, sandbox, or sensitive-data risk.Security boundary, credential, authz, sandbox, or sensitive-data risk.issue-rating: 🌊 off-meta tidepoolIssue quality rating does not apply to this item.Issue quality rating does not apply to this item.maintainerMaintainer-authored PRMaintainer-authored PR
Description
Metadata
Metadata
Assignees
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:needs-security-reviewClawSweeper marked this issue as needing security-sensitive review.ClawSweeper marked this issue as needing security-sensitive review.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.enhancementNew feature or requestNew feature or requestimpact:securitySecurity boundary, credential, authz, sandbox, or sensitive-data risk.Security boundary, credential, authz, sandbox, or sensitive-data risk.issue-rating: 🌊 off-meta tidepoolIssue quality rating does not apply to this item.Issue quality rating does not apply to this item.maintainerMaintainer-authored PRMaintainer-authored PR
Type
Fields
Priority
None yet
Summary
Rename the Codex plugin destructive-action policy value from
"always"to"ask".Problem to solve
plugins.entries.codex.config.codexPlugins[*].allow_destructive_actions: "always"means that every plugin write or destructive action must ask the user for approval. The value name describes neither the user-visible behavior nor the approval boundary, making configuration and documentation easy to misread.Proposed solution
Replace the string policy with
"ask"across the manifest, public types, runtime behavior, persisted binding shape, tests, examples, and documentation. This should be a hard contract cut: old"always"values fail validation and are not silently accepted, normalized, or migrated.Keep
true,false, and"auto"unchanged. Ensure"ask"keeps write/destructive tools available, clears durable per-tool approval overrides, and routes approval through the human reviewer on thread start/resume, turn start, and side-thread fork without changing sibling app policies.Alternatives considered
"always"as an alias: rejected because it preserves the contradictory public contract and creates dual behavior indefinitely.Impact
Evidence/examples
"always": feat(codex): add always plugin approval mode #97123.approvalsRevieweroverrides across thread and subsequent-turn configuration, so the replacement must be carried through thread start/resume, turn start, and fork paths.Additional information
This is intentionally backward-incompatible for this one string value. Boolean policies and
"auto"remain unchanged.