Summary

In manager-BeivTKDc.js, the awaitPendingManagerWork function is called during session/manager close() to await in-flight memory sync and provider initialization. It silently discards all errors from both operations with empty catch {} blocks — no logging, no diagnostic, no fallback.

Code

async function awaitPendingManagerWork(params) {
    if (params.pendingSync) try {
        await params.pendingSync;
    } catch {}                          // silent swallow
    if (params.pendingProviderInit) try {
        await params.pendingProviderInit;
    } catch {}                          // silent swallow
}

Impact

If a memory sync fails during close (SQLite locking, disk full, filesystem error) or provider init fails, the failure is completely invisible. This can cause silent data loss of memory/index changes on shutdown.

Evidence of inconsistency

The adjacent code on the same file (around lines 460-464) for a similar operation uses params.onError(err) to log errors, confirming these empty catches are not a deliberate design choice for this specific function.

Suggested fix

At minimum, log the error. For example:

async function awaitPendingManagerWork(params) {
    if (params.pendingSync) try {
        await params.pendingSync;
    } catch (err) {
        params.onError?.(err);
    }
    if (params.pendingProviderInit) try {
        await params.pendingProviderInit;
    } catch (err) {
        params.onError?.(err);
    }
}