-
-
Notifications
You must be signed in to change notification settings - Fork 80.7k
Async/cron command results can drop action-critical auth/setup prompt lines during output truncation #96346
Copy link
Copy link
Closed
Labels
P1High-priority user-facing bug, regression, or broken workflow.High-priority user-facing bug, regression, or broken workflow.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:queueable-fixClawSweeper marked this issue as an existing queue_fix_pr work candidate.ClawSweeper marked this issue as an existing queue_fix_pr work candidate.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:auth-providerAuth, provider routing, model choice, or SecretRef resolution may break.Auth, provider routing, model choice, or SecretRef resolution may break.impact:message-lossChannel message delivery can be lost, duplicated, or misrouted.Channel message delivery can be lost, duplicated, or misrouted.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.no-staleExclude from stale automationExclude from stale automation
Description
Metadata
Metadata
Assignees
Labels
P1High-priority user-facing bug, regression, or broken workflow.High-priority user-facing bug, regression, or broken workflow.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:queueable-fixClawSweeper marked this issue as an existing queue_fix_pr work candidate.ClawSweeper marked this issue as an existing queue_fix_pr work candidate.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:auth-providerAuth, provider routing, model choice, or SecretRef resolution may break.Auth, provider routing, model choice, or SecretRef resolution may break.impact:message-lossChannel message delivery can be lost, duplicated, or misrouted.Channel message delivery can be lost, duplicated, or misrouted.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.no-staleExclude from stale automationExclude from stale automation
Type
Fields
Priority
None yet
Summary
Async/cron command results can drop action-critical auth/setup prompt lines during output truncation. When a command emits a Microsoft device-code login prompt, the login URL may survive in the delivered result but the short device code and next-action instruction are lost, making the prompt unactionable.
This is the interactive complement to PR #95809 (cron broadcast delivery redaction). Same class of sensitive/action-critical output, opposite requirement by context: interactive command results the user is awaiting should preserve these lines; broadcast delivery should redact them.
Environment
timeoutSeconds,outputMaxBytesopenclaw cron run --wait/ process poll/log / approval follow-up summariesReproduction (synthetic example only)
Create a cron command job that prints a Microsoft device-code prompt followed by enough filler output to trigger the 200 KB default output cap:
{ "name": "test-async-preservation", "schedule": { "kind": "at", "at": "2099-01-01T00:00:00Z" }, "payload": { "kind": "command", "timeoutSeconds": 30, "outputMaxBytes": 900 }, "deleteAfterRun": true }Expected behaviour
The delivered run result includes:
https://login.microsoft.com/deviceenter the code FAKE-CODE-270 to authenticate[output truncated: stdout omitted ... Recovery: openclaw cron runs --id <job> --run-id <run>]Actual behaviour
The delivered summary contains only the filler tail lines and the truncation note. The login URL and device code are absent from the user-facing result.
Impact
Suggested Fix
Introduce a shared action-critical output classifier that identifies lines matching:
login.microsoft.com/device,microsoft.com/devicelogin)code: XXXX-XXXX,enter the code ...)The classifier should be shared by two call sites:
Acceptance Criteria
Related Work
fix(cron): redact command output in delivery— addresses the broadcast/cron delivery half using the same value class. This issue covers the interactive/async preservation half.Verification
Tested locally with identical fake/synthetic device-code prompt data only. The local mitigation (installed runtime hotfix on [email protected]) was verified by:
All passed with synthetic data. The hotfix was overwritten by the subsequent v2026.6.8 package upgrade, confirming the need for a durable source fix.