-
-
Notifications
You must be signed in to change notification settings - Fork 80.7k
skill_workshop apply times out ("Approval timed out") on large proposals (~28KB) #94249
Copy link
Copy link
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:needs-maintainer-reviewClawSweeper marked this issue as needing maintainer review before automation.ClawSweeper marked this issue as needing maintainer review before automation.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:needs-security-reviewClawSweeper marked this issue as needing security-sensitive review.ClawSweeper marked this issue as needing security-sensitive review.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:securitySecurity boundary, credential, authz, sandbox, or sensitive-data risk.Security boundary, credential, authz, sandbox, or sensitive-data risk.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.
Description
Metadata
Metadata
Assignees
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:needs-maintainer-reviewClawSweeper marked this issue as needing maintainer review before automation.ClawSweeper marked this issue as needing maintainer review before automation.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:needs-security-reviewClawSweeper marked this issue as needing security-sensitive review.ClawSweeper marked this issue as needing security-sensitive review.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:securitySecurity boundary, credential, authz, sandbox, or sensitive-data risk.Security boundary, credential, authz, sandbox, or sensitive-data risk.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.
Type
Fields
Priority
None yet
Summary
skill_workshopaction=applyconsistently returns{"status":"error","error":"Approval timed out"}for a large proposal. It does not partially apply (proposal stayspending, live SKILL.md unchanged), so retrying is safe — but the apply never completes through the tool.Environment
Repro
skill_workshopso the proposal'sPROPOSAL.mdis large — in our case 27,986 bytes (a workspace skill,client-monitoring).skill_workshop action=applywith the proposal id.error: "Approval timed out". Repeated 3× consecutively — consistent, not transient.Expected
Apply writes
PROPOSAL.md-> liveSKILL.mdand marks the proposalapplied.Actual
Times out at the tool layer every time. After each attempt: proposal
status: pending, live SKILL.md unchanged (no partial write).create/update(which write a similarly-sized PROPOSAL.md) work fine — onlyapplytimes out, which suggests the timeout is on apply's write/transition step, not on accepting the body.Impact
Low severity (a clean manual workaround exists: verify still-pending, copy PROPOSAL.md to the live SKILL.md, reconcile proposals.json/proposal.json to applied). But to anyone who doesn't know to verify, it looks like 'apply failed' and may get retried or abandoned. Larger skill docs will keep hitting this.
Suggested fix
Raise the apply timeout, or stream/chunk the apply write, or make apply async with a status the caller can poll. A ~28KB doc write shouldn't time out.