-
-
Notifications
You must be signed in to change notification settings - Fork 80.7k
minSecurity inverted — security="full" session override clamped to "allowlist" by agent config #91283
Copy link
Copy link
Closed as not planned
Closed as not planned
Copy link
Labels
P3Low-priority cleanup, docs, polish, ergonomics, or speculative work.Low-priority cleanup, docs, polish, ergonomics, or speculative work.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:needs-security-reviewClawSweeper marked this issue as needing security-sensitive review.ClawSweeper marked this issue as needing security-sensitive review.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:securitySecurity boundary, credential, authz, sandbox, or sensitive-data risk.Security boundary, credential, authz, sandbox, or sensitive-data risk.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.securitySecurity documentationSecurity documentation
Description
Metadata
Metadata
Assignees
Labels
P3Low-priority cleanup, docs, polish, ergonomics, or speculative work.Low-priority cleanup, docs, polish, ergonomics, or speculative work.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:needs-security-reviewClawSweeper marked this issue as needing security-sensitive review.ClawSweeper marked this issue as needing security-sensitive review.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:securitySecurity boundary, credential, authz, sandbox, or sensitive-data risk.Security boundary, credential, authz, sandbox, or sensitive-data risk.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.securitySecurity documentationSecurity documentation
Type
Fields
Priority
None yet
In
exec-approvals.js,minSecurityhas the rank order backwards:This treats
fullas the MOST restrictive (rank 2) instead of the LEAST restrictive. WhenresolveExecHostApprovalContextcalls:a session override of
security="full"gets clamped down to the agent'ssecurity="allowlist"becauseorder["full"](2) >order["allowlist"](1), so it returns"allowlist".Note
execSecurityFloorRankin the same file already uses the correct order wherefull=0is least restrictive — so the fix is swappingminSecurity's order to match:Steps to reproduce:
exec.security: "full"in a session or configsecurity: "allowlist"exec denied: allowlist missImpact: Users can never have per-session
security="full"unless the agent config is also"full"(which applies to all sessions). Thediscord.execApprovalsschema also lacks asecurity/askfield, so there's no way to set per-channel exec security either.Found in: OpenClaw 2026.6.1
Related: #58691, #59079