-
-
Notifications
You must be signed in to change notification settings - Fork 80.7k
[Bug]: Ctrl+C during upgrade doctor does not abort the installer #82304
Copy link
Copy link
Closed
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:crash-loopCrash, hang, restart loop, or process-level availability failure.Crash, hang, restart loop, or process-level availability failure.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.maturity:stableIssue affects a taxonomy feature currently scored M4/M5.Issue affects a taxonomy feature currently scored M4/M5.
Description
Metadata
Metadata
Assignees
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:crash-loopCrash, hang, restart loop, or process-level availability failure.Crash, hang, restart loop, or process-level availability failure.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.maturity:stableIssue affects a taxonomy feature currently scored M4/M5.Issue affects a taxonomy feature currently scored M4/M5.
Type
Fields
Priority
None yet
Problem
When running
curl -fsSL https://openclaw.ai/install.sh | bashon an upgrade, the installer runsopenclaw doctorinteractively. Doctor may reveal many skills with missing requirements (1password CLI, ffmpeg, jq, etc.). The user naturally wants to press Ctrl+C to abort, install those dependencies, and re-run later.But Ctrl+C does not work:
@clack/promptsinsideopenclaw doctorcatches SIGINT and treats it as "No" -- doctor exits 0, not 130trap ... INT-- onlytrap ... EXITfor temp file cleanup&& doctor_ok=1pattern prevents bash's cooperative SIGINT exitshould_open_dashboardis set totruebefore the interactive section, so the script continues to open a browser tohttp://127.0.0.1:18789/which may be deadThe user pressed Ctrl+C to abort, but instead gets a browser tab to a dead address.
Expected behavior
Ctrl+C at any point during the installer should cleanly exit with temp file cleanup and a clear "Installation interrupted" message.
Affected file
scripts/install.shRelated