Codex review: keeping this open for maintainer follow-up; there is still a little grit to resolve.

Summary
Keep open: current main still hardcodes /usr/bin/scp, and the linked open PR is the active fix path with closing syntax, so this issue should close only after that PR lands.

Reproducibility: yes. Current main unconditionally spawns /usr/bin/scp, so a host where scp exists on PATH but not at that absolute path has a high-confidence failure before SSH connection setup.

Next step
A linked open PR already carries the focused fix and closes this issue, so a separate repair job would duplicate active work.

Review details

Best possible solution:

Review and land the linked PR if maintainers accept PATH-based scp lookup, keeping the change local to auto-reply media staging and preserving the existing host/path validation.

Do we have a high-confidence way to reproduce the issue?

Yes. Current main unconditionally spawns /usr/bin/scp, so a host where scp exists on PATH but not at that absolute path has a high-confidence failure before SSH connection setup.

Is this the best way to solve the issue?

Yes. Spawning scp by command name while preserving no-shell execution, existing arguments, and existing host/path validation is the narrowest maintainable fix for the reported portability bug.

What I checked:

Current main hardcodes scp path: scpFile calls spawn("/usr/bin/scp", ...) in the remote sandbox media staging helper. (src/auto-reply/reply/stage-sandbox-media.ts:321, 79e31421225b)
Remote staging path is real: Remote media staging calls stageRemoteFileIntoRoot when MediaRemoteHost is present, then reaches scpFile after the remote attachment root check. (src/auto-reply/reply/stage-sandbox-media.ts:94, 79e31421225b)
Existing scp argument validation remains relevant: normalizeScpRemoteHost and normalizeScpRemotePath constrain host/path input before spawning scp, so the narrow fix does not require shell parsing. (src/infra/scp-host.ts:18, 79e31421225b)
Docs define SCP remote attachment behavior: The iMessage docs state remote attachment paths can be fetched via SCP when remoteHost is set and note strict host-key checking. Public docs: docs/channels/imessage.md. (docs/channels/imessage.md:407, 79e31421225b)
Linked PR is open and targeted: The linked PR is open, has head 3382740b2c201d1614813d40201a3f15c526c5ac, and its patch changes only the scp executable string plus a regression assertion and changelog entry. (src/auto-reply/reply/stage-sandbox-media.ts:321, 3382740b2c20)
PATH behavior checked: Local Node process proof showed spawn('scp', ...) fails with ENOENT when PATH is empty, while spawn('/usr/bin/scp', ...) bypasses PATH, matching the reported portability issue.

Likely related people:

steipete: Peter Steinberger appears repeatedly in the sandbox media staging history, including the original inbound staging work, remote SCP/SSH hardening, and later security refactors around this path. (role: major maintainer and adjacent owner; confidence: high; commits: 995f5959af16, 49d0def6d1e8, 4a80311628fb; files: src/auto-reply/reply/stage-sandbox-media.ts, src/infra/scp-host.ts, docs/channels/imessage.md)
tyler6204: The remote attachment support for VM/SSH deployments appears to date to Tyler Yust's iMessage remote attachment work, which feeds this SCP staging path. (role: introduced related remote attachment behavior; confidence: medium; commits: 7a9ff182608b; files: extensions/imessage, src/auto-reply/reply/stage-sandbox-media.ts)
Daev Mithran: Local blame on the current checkout attributes the present stageSandboxMedia helper and scpFile implementation to this current-main history, though the commit appears broad rather than the original feature introduction. (role: current-line history owner; confidence: medium; commits: 9e1e59717ffd; files: src/auto-reply/reply/stage-sandbox-media.ts, src/auto-reply/reply.stage-sandbox-media.scp-remote-path.test.ts)

Remaining risk / open question:

The exact host layout with scp available only outside /usr/bin was not live-run here; the failure is source-reproducible from the hardcoded executable path.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 79e31421225b.

Uh oh!

Uh oh!

Sandbox media staging hardcodes /usr/bin/scp #79242

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions