-
-
Notifications
You must be signed in to change notification settings - Fork 80.7k
doctor --fix fails atomically when config has multiple validation errors, preventing fixes from persisting #77802
Copy link
Copy link
Closed as not planned
Closed as not planned
Copy link
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:needs-live-reproClawSweeper needs live local, crabbox, or manual validation to confirm this issue.ClawSweeper needs live local, crabbox, or manual validation to confirm this issue.clawsweeper:needs-maintainer-reviewClawSweeper marked this issue as needing maintainer review before automation.ClawSweeper marked this issue as needing maintainer review before automation.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.impact:data-lossCan lose, corrupt, or silently drop user/session/config data.Can lose, corrupt, or silently drop user/session/config data.issue-rating: 🐚 platinum hermitGood issue quality with a plausible reproduction path needing some confirmation.Good issue quality with a plausible reproduction path needing some confirmation.maturity:stableIssue affects a taxonomy feature currently scored M4/M5.Issue affects a taxonomy feature currently scored M4/M5.staleMarked as stale due to inactivityMarked as stale due to inactivity
Description
Metadata
Metadata
Assignees
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:needs-live-reproClawSweeper needs live local, crabbox, or manual validation to confirm this issue.ClawSweeper needs live local, crabbox, or manual validation to confirm this issue.clawsweeper:needs-maintainer-reviewClawSweeper marked this issue as needing maintainer review before automation.ClawSweeper marked this issue as needing maintainer review before automation.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.impact:data-lossCan lose, corrupt, or silently drop user/session/config data.Can lose, corrupt, or silently drop user/session/config data.issue-rating: 🐚 platinum hermitGood issue quality with a plausible reproduction path needing some confirmation.Good issue quality with a plausible reproduction path needing some confirmation.maturity:stableIssue affects a taxonomy feature currently scored M4/M5.Issue affects a taxonomy feature currently scored M4/M5.staleMarked as stale due to inactivityMarked as stale due to inactivity
Type
Fields
Priority
None yet
Bug Description
After upgrading OpenClaw, running
openclaw doctor --fixenters a broken loop where no fixes can persist because the tool fails atomically on any validation error.Reproduction Steps
plugins.denyreferences a non-existent plugin (openclaw-weixin)models.providers.bailian.models.*.compat.thinkingFormathas invalid enum valuesplugins.allow/plugins.entriesreferences (acpx)openclaw doctor— it reports all issues and saysRun "openclaw doctor --fix" to apply changes.openclaw doctor --fixObserved Behavior
--fixstarts by auto-restoring config from last-known-good because the current config is invalid:Set plugins.bundledDiscovery="compat"Installed missing configured plugin "feishu"plugins.allow: removed 1 stale plugin id (acpx)plugins.entries: removed 1 stale plugin entry (acpx)openclaw doctoragain — the staleacpxreferences are back, and all prompts to run--fixreappear.Expected Behavior
doctor --fixshould:Environment
Impact
This makes
doctor --fixeffectively unusable for real-world configs that accumulate multiple issues across upgrades. Users are forced to manually editopenclaw.jsoninstead of using the automated repair tool.