Skip to content

This issue is raised to flag critical structural and architectural conflicts in PR #75441 that prevent it from being a viable path for main stability. #75651

@davidangularme

Description

@davidangularme
  1. Scope Mismatch with Issue [Bug]: Empty catch blocks swallow errors silently, hindering debugging #63423
    PR fix(config): log observe recovery write failures #75441 is currently tagged with Fixes [Bug]: Empty catch blocks swallow errors silently, hindering debugging #63423. However, a file-diff audit shows that the PR does not address the required changes in:

src/pairing/

src/infra/

The current implementation is restricted to src/config/io.observe-recovery.ts. Claiming full resolution of #63423 is factually incorrect and misleads the project's tracking of outstanding technical debt.

  1. Dependency Breakage (Commit ad3e4db)
    The CI failures (3s exit) in fix(config): log observe recovery write failures #75441 are due to a direct conflict with the recent refactor by @steipete.

The Conflict: PR #75441 attempts to import observeConfigSnapshot and observeConfigSnapshotSync from ./io.observe-recovery.js.

The Reality: Commit ad3e4db ("refactor: trim unused exports") moved these functions to internal-only scope in src/config/io.ts.

By attempting to re-expose or bypass these internal boundaries, #75441 violates the current architectural direction of the project.

  1. Impact on Stability
    The stable "restore-copy" audit fixes (originally from fix(config): surface backup restore copy failures in audit and logs #70515) are currently bundled with the unstable and structurally invalid extensions in fix(config): log observe recovery write failures #75441. This "all-or-nothing" packaging is holding a verified fix hostage to a broken build.

Recommended Action:

Decouple the verified recovery-audit fixes from the invalid health-state expansion.

Re-evaluate #75441 once its scope is properly aligned with the files listed in #63423.

Uphold the encapsulation boundaries established in ad3e4db.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions