-
-
Notifications
You must be signed in to change notification settings - Fork 80.7k
[Bug]: Telegram DM fabricates silent-reply chatter for no-visible-response turns #70628
Copy link
Copy link
Closed as not planned
Closed as not planned
Copy link
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:message-lossChannel message delivery can be lost, duplicated, or misrouted.Channel message delivery can be lost, duplicated, or misrouted.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.staleMarked as stale due to inactivityMarked as stale due to inactivity
Description
Metadata
Metadata
Assignees
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:message-lossChannel message delivery can be lost, duplicated, or misrouted.Channel message delivery can be lost, duplicated, or misrouted.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.staleMarked as stale due to inactivityMarked as stale due to inactivity
Type
Fields
Priority
None yet
Summary
Telegram direct-message turns that end with no visible final reply can still emit a synthetic user-facing bubble like "No added response from me." instead of staying silent.
Reproduction shape
This reproduces when:
telegramA real incident produced repeated Telegram DM bubbles such as:
No added response from me.Root cause
There are two pieces that combine into the leak:
extensions/telegram/src/bot-message-dispatch.ts!queuedFinal && !sentFallback && !dispatchError && !deliverySummary.deliveredpath[{ text: "NO_REPLY" }]src/infra/outbound/payloads.ts+ silent-reply policy defaultssilentReply.direct = "disallow"silentReplyRewrite.direct = trueNO_REPLYis rewritten into visible filler text likeNo added response from me.That means an intentionally silent Telegram DM turn is converted into misleading chatter.
Why this is a bug
The adapter already has a separate fallback path for actual failures:
This no-visible-response path is different: it can represent an intentionally silent turn. In that case the Telegram adapter should not fabricate a user-visible message.
Expected behavior
For Telegram DMs:
NO_REPLYfallback bubbleAdditional note
The current test suite explicitly encodes the buggy behavior in
extensions/telegram/src/bot-message-dispatch.test.tsby expecting a DM no-visible-response turn to be rewritten through silent-reply fallback.Proposed fix
In
extensions/telegram/src/bot-message-dispatch.ts:I have a PR ready with:
extensions/telegram/src/bot-message-dispatch.tsextensions/telegram/src/bot-message-dispatch.test.ts