-
-
Notifications
You must be signed in to change notification settings - Fork 80.7k
fix(channels): extend user-visible error fallback to Discord, Slack, Signal, WhatsApp #60812
Copy link
Copy link
Closed as not planned
Closed as not planned
Copy link
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:queueable-fixClawSweeper marked this issue as an existing queue_fix_pr work candidate.ClawSweeper marked this issue as an existing queue_fix_pr work candidate.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:message-lossChannel message delivery can be lost, duplicated, or misrouted.Channel message delivery can be lost, duplicated, or misrouted.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.staleMarked as stale due to inactivityMarked as stale due to inactivity
Description
Metadata
Metadata
Assignees
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:queueable-fixClawSweeper marked this issue as an existing queue_fix_pr work candidate.ClawSweeper marked this issue as an existing queue_fix_pr work candidate.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:message-lossChannel message delivery can be lost, duplicated, or misrouted.Channel message delivery can be lost, duplicated, or misrouted.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.staleMarked as stale due to inactivityMarked as stale due to inactivity
Type
Fields
Priority
None yet
Problem
When a message dispatch fails (provider error, rate limit, empty response), Telegram now sends the user a meaningful fallback message. All other channels silently drop the failure — the user receives nothing and has no way to know something went wrong.
Current behavior per channel
"Sorry, I encountered an error..."string (no error routing)Proposed fix
Add the same fallback pattern to each channel's dispatch site:
lastErrorviaonErrorcallback and outer try/catchresolveFailoverReasonFromError+EmptyResponseErrorrouting (same logic as Telegram)Extract the error-message-selection logic into a shared helper (e.g.
src/auto-reply/reply/delivery-fallback.ts) so it isn't duplicated across channel files.Related
EmptyResponseErrorinsrc/agents/model-fallback.ts)resolveFailoverReasonFromErroralready handles rate-limit / auth / timeout classification