Skip to content

pnpm check fails on main with tsgo errors in irc/mattermost/msteams/nextcloud-talk #52558

@jalehman

Description

@jalehman

Summary

pnpm check currently fails on origin/main because tsgo reports TypeScript errors in files outside PR #25260's docs-only diff.

Reproduction

pnpm check

Observed on origin/main at:

  • commit: 645c9210b31b8ca7d7b8b56a33912b8174475652
  • subject: style(format): fix provider test formatting drift

Failing errors

extensions/irc/src/setup-core.test.ts(130,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/irc/src/setup-core.test.ts(136,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/irc/src/setup-core.test.ts(142,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/mattermost/src/setup-core.test.ts(69,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/mattermost/src/setup-core.test.ts(77,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/mattermost/src/setup-core.test.ts(85,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/msteams/src/reply-dispatcher.ts(107,26): error TS2304: Cannot find name 'MSTeamsRenderedMessage'.
extensions/msteams/src/reply-dispatcher.ts(109,41): error TS2304: Cannot find name 'MSTeamsRenderedMessage'.
extensions/msteams/src/reply-dispatcher.ts(157,20): error TS2339: Property 'warn' does not exist on type 'MSTeamsMonitorLogger'.
extensions/nextcloud-talk/src/setup-core.test.ts(107,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/nextcloud-talk/src/setup-core.test.ts(114,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/nextcloud-talk/src/setup-core.test.ts(121,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.

Likely introducing commits

  • f9a063ee2d test(irc): cover setup adapter
  • fdcf26ffd3 test(mattermost): cover setup adapter
  • 71113ea0cb test(nextcloud-talk): cover setup adapter
  • 8b5eeba386 fix(msteams): batch multi-block replies into single continueConversation call (#29379) (#49587)

Why this matters

This is blocking scripts/pr-prepare gates 25260 for PR #25260 even though that PR still only changes:

  • AGENTS.md
  • CHANGELOG.md
  • skills/sag/SKILL.md

The previous unrelated format:check blocker cleared on main; this new tsgo failure is now the gate stopper.

Metadata

Metadata

Assignees

No one assigned

    Labels

    maintainerMaintainer-authored PR

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions