-
-
Notifications
You must be signed in to change notification settings - Fork 69.5k
pnpm check fails on main with tsgo errors in irc/mattermost/msteams/nextcloud-talk #52558
Copy link
Copy link
Open
Labels
maintainerMaintainer-authored PRMaintainer-authored PR
Description
Summary
pnpm check currently fails on origin/main because tsgo reports TypeScript errors in files outside PR #25260's docs-only diff.
Reproduction
pnpm checkObserved on origin/main at:
- commit:
645c9210b31b8ca7d7b8b56a33912b8174475652 - subject:
style(format): fix provider test formatting drift
Failing errors
extensions/irc/src/setup-core.test.ts(130,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/irc/src/setup-core.test.ts(136,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/irc/src/setup-core.test.ts(142,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/mattermost/src/setup-core.test.ts(69,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/mattermost/src/setup-core.test.ts(77,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/mattermost/src/setup-core.test.ts(85,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/msteams/src/reply-dispatcher.ts(107,26): error TS2304: Cannot find name 'MSTeamsRenderedMessage'.
extensions/msteams/src/reply-dispatcher.ts(109,41): error TS2304: Cannot find name 'MSTeamsRenderedMessage'.
extensions/msteams/src/reply-dispatcher.ts(157,20): error TS2339: Property 'warn' does not exist on type 'MSTeamsMonitorLogger'.
extensions/nextcloud-talk/src/setup-core.test.ts(107,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/nextcloud-talk/src/setup-core.test.ts(114,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
extensions/nextcloud-talk/src/setup-core.test.ts(121,7): error TS2722: Cannot invoke an object which is possibly 'undefined'.
Likely introducing commits
f9a063ee2dtest(irc): cover setup adapterfdcf26ffd3test(mattermost): cover setup adapter71113ea0cbtest(nextcloud-talk): cover setup adapter8b5eeba386fix(msteams): batch multi-block replies into single continueConversation call (#29379) (#49587)
Why this matters
This is blocking scripts/pr-prepare gates 25260 for PR #25260 even though that PR still only changes:
AGENTS.mdCHANGELOG.mdskills/sag/SKILL.md
The previous unrelated format:check blocker cleared on main; this new tsgo failure is now the gate stopper.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
maintainerMaintainer-authored PRMaintainer-authored PR
Type
Fields
Give feedbackNo fields configured for issues without a type.