-
-
Notifications
You must be signed in to change notification settings - Fork 80.7k
doctor: false positive cleanup hint for active gateway LaunchAgent plist #52510
Copy link
Copy link
Open
BingqingLyu/openclaw
#1247Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:auth-providerAuth, provider routing, model choice, or SecretRef resolution may break.Auth, provider routing, model choice, or SecretRef resolution may break.impact:crash-loopCrash, hang, restart loop, or process-level availability failure.Crash, hang, restart loop, or process-level availability failure.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.maturity:stableIssue affects a taxonomy feature currently scored M4/M5.Issue affects a taxonomy feature currently scored M4/M5.
Description
Metadata
Metadata
Assignees
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.impact:auth-providerAuth, provider routing, model choice, or SecretRef resolution may break.Auth, provider routing, model choice, or SecretRef resolution may break.impact:crash-loopCrash, hang, restart loop, or process-level availability failure.Crash, hang, restart loop, or process-level availability failure.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.maturity:stableIssue affects a taxonomy feature currently scored M4/M5.Issue affects a taxonomy feature currently scored M4/M5.
Type
Fields
Priority
None yet
Bug Description
openclaw doctorsuggests removing the active gateway LaunchAgent plist as a "cleanup hint," even when that plist is the currently running gateway service.Steps to Reproduce
openclaw doctorExpected Behavior
Doctor should detect that
ai.openclaw.gatewayis the active gateway service (vialaunchctl listor PID check) and NOT suggest removing it. The cleanup hint should only appear for genuinely orphaned/stale plists.Actual Behavior
Doctor always suggests removing the plist, even when it is the live service keeping the gateway running. Following the hint causes downtime until the plist is recreated and the service reloaded.
Additional Issue: SecretRef exit code
openclaw doctoralso exits with code 1 when it encountersexec:keychain:SecretRef values in the config:This is expected behavior - keychain secrets are resolved at gateway runtime, not by the doctor CLI. Doctor should either:
exec:sources, orEnvironment