-
-
Notifications
You must be signed in to change notification settings - Fork 69.5k
Phase 10: Fix dedicated ACA provisioning — env vars, retry logic, stuck orgs #48116
Copy link
Copy link
Closed
Description
Summary
Fix dedicated ACA provisioning so it actually works:
- Missing env vars on sidekyk-admin:
AZURE_SUBSCRIPTION_ID,AZURE_RESOURCE_GROUP,AZURE_ACR_LOGIN_SERVER,AZURE_WORKER_IMAGE— provisioner couldn't initialize - Corrupted
AZURE_ACA_ENVIRONMENT_ID: Git Bash mangled/subscriptions/...→C:/Program Files/Git/subscriptions/... - Incomplete
baseWorkerEnv: Only passedOPENAI_API_KEY+DATABASE_URL— now passes WhatsApp, Service Bus, Redis, and admin API vars - No retry logic: Provisioning was fire-and-forget with no retries — now 3 attempts with exponential backoff
- Stuck org recovery: New
POST /api/admin/isolation/retry-stuckendpoint to retry all orgs stuck inerrororprovisioningstate
Changes
admin/src/index.ts: ExpandedbaseWorkerEnvwith all required dedicated worker env varsadmin/src/routes/users.ts: AddedprovisionWithRetry()with 3 retries, exponential backoff (5s, 10s, 20s)admin/src/routes/isolation.ts: Added retry loop in PUT handler +POST /api/admin/isolation/retry-stuckendpointscripts/deploy-azure.sh: Added pass-through env vars for dedicated workers- Tests: 4 user tests + 12 isolation tests
- Smoke tests updated for Phase 10
Acceptance Criteria
-
AZURE_SUBSCRIPTION_IDset on sidekyk-admin → AzureProvisioner initializes -
baseWorkerEnvpasses all required env vars to dedicated workers - Provisioning retries 3x with exponential backoff before setting
error -
POST /api/admin/isolation/retry-stuckrecovers stuck orgs - All unit tests pass (58 admin + 123 shared)
- Prod smoke tests pass
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Give feedbackNo fields configured for issues without a type.