-
-
Notifications
You must be signed in to change notification settings - Fork 69.5k
[Bug]: guard missing model.input in model list/scan paths #35416
Description
Bug type
Behavior bug (incorrect output/state without crash)
Summary
Model list/scan paths still assume model.input exists; when custom provider models omit it, OpenClaw can throw runtime TypeError in current main.
Steps to reproduce
- Configure/use a custom provider model entry that omits
input. - Run model list/scan paths (for example model listing and OpenRouter probing).
- Observe errors from
.joinor.includesonundefined.
Expected behavior
If input is missing, list/scan paths should fall back safely (for example text) and not throw.
Actual behavior
upstream/main still has direct dereferences:
src/commands/models/list.registry.ts:147usesmodel.input.join("+")src/agents/model-scan.ts:329andsrc/agents/model-scan.ts:475usemodel.input.includes(...)
OpenClaw version
main branch (checked on March 5, 2026)
Operating system
Cross-platform code path (repro not OS-specific)
Install method
Source checkout / main branch verification
Logs, screenshots, and evidence
Code evidence on main:
- src/commands/models/list.registry.ts:147
- src/agents/model-scan.ts:329
- src/agents/model-scan.ts:475
Related PR with fix: #12191
Previous issue that was closed stale: #12165Impact and severity
Affected: Users with custom provider model metadata lacking input.
Severity: Medium to High depending on workflow; can block list/scan usage.
Frequency: Deterministic when input is absent.
Consequence: Runtime exceptions in model inspection/scanning paths.
Additional information
This intentionally supersedes #12165 (closed not planned) because the underlying behavior is still present in main as of March 5, 2026.