-
-
Notifications
You must be signed in to change notification settings - Fork 69.3k
Strict config validation rejects legitimate fields (comment, skills) #23385
Copy link
Copy link
Closed
Description
Bug Description
After commit d1e9490f9 ("enforce strict config validation"), all Zod config schemas use .strict() which rejects unknown keys. Two legitimate fields were missed and are now being rejected:
1. comment on bindings
- Schema:
src/config/zod-schema.agents.ts—BindingsSchemamissingcomment: z.string().optional() - Type:
src/config/types.agents.ts—AgentBindingmissingcomment?: string
2. skills on agent entries
- Schema:
src/config/zod-schema.agent-runtime.ts—AgentEntrySchemamissingskills: z.array(z.string()).optional() - Type:
src/config/types.agents.ts—AgentConfigmissingskills?: string[] - Note:
skillswas already supported on channel-level configs but not on per-agent config
Impact
Agents with these fields in their config fail to start with validation errors.
Fix
Four files need changes:
src/config/zod-schema.agent-runtime.ts— addskillssrc/config/zod-schema.agents.ts— addcommentsrc/config/types.agents.ts— add both to types
Suggested Prevention
- Audit existing configs when adding strict validation
- Add integration tests that validate real-world config examples
- Consider a "warn on unknown keys" mode before hard rejection
Version
Affects: 2026.2.19+ (after strict validation was enforced)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Give feedbackNo fields configured for issues without a type.