Skip to content

[Bug]: terminal.text C1 filtering lacks regression coverage #103435

Description

@steipete

Bug type

Behavior bug (incorrect output/state without crash)

Beta release blocker

No

Summary

The landed terminal.text C1-control fix in #103274 is not covered by a focused regression test on current main.

Steps to reproduce

  1. Inspect src/gateway/terminal/buffer-text.ts on current main; renderTerminalBufferText removes U+0080 through U+009F.
  2. Inspect src/gateway/terminal/buffer-text.test.ts.
  3. Observe that the tests cover ESC-based ANSI, C0 BEL, tabs, CR/LF, and OSC, but do not exercise the C1 range or its boundaries.

Expected behavior

The renderer test should prove that every residual C1 control from U+0080 through U+009F is removed, DEL is still removed, adjacent U+00A0 and tabs survive, and complete C1 CSI sequences continue to be stripped by the shared ANSI scanner.

Actual behavior

The production fix is present and works, but no committed test fails if its C1 range is narrowed or removed.

OpenClaw version

main after a3f9f35 (unreleased)

Operating system

All supported platforms; this is platform-independent string rendering.

Install method

Source checkout

Model

Not applicable

Provider / routing chain

Not applicable

Additional provider/model setup details

Not applicable

Logs

Blacksmith Testbox tbx_01kx58g1v7z1zta9r4r28pkrpq:
src/gateway/terminal/buffer-text.test.ts — 4 files passed, 24 tests passed

Screenshots, recordings, and evidence

Impact and severity

  • Affected: release maintainers and future changes to the terminal.text renderer.
  • Severity: low runtime risk, concrete release-proof gap.
  • Frequency: always; current main has no C1-specific assertion.
  • Consequence: a future off-by-one or removal regression can pass the existing focused suite.

Additional information

Keep the follow-up test-only. No production behavior change is needed.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingmaintainerMaintainer-authored PR

Type

No type

Fields

Priority

None yet

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions