fix telegram thread binding review blockers

gumadeiras · gumadeiras · commit ff9a55cc8a62 · 2026-05-18T15:00:43.000+03:00
diff --git a/extensions/telegram/src/channel.ts b/extensions/telegram/src/channel.ts
@@ -682,7 +682,7 @@ export const telegramPlugin = createChatChannelPlugin({
     },
     conversationBindings: {
       supportsCurrentConversationBinding: true,
-      defaultTopLevelPlacement: "current",
+      defaultTopLevelPlacement: "child",
       resolveConversationRef: ({
         accountId: _accountId,
         conversationId,
diff --git a/extensions/telegram/src/thread-bindings.test.ts b/extensions/telegram/src/thread-bindings.test.ts
@@ -6,6 +6,7 @@ import { getSessionBindingService } from "openclaw/plugin-sdk/conversation-runti
 import { resolveStateDir } from "openclaw/plugin-sdk/state-paths";
 import { importFreshModule } from "openclaw/plugin-sdk/test-fixtures";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { telegramPlugin } from "./channel.js";
 
 const writeJsonFileAtomicallyMock = vi.hoisted(() => vi.fn());
 const readAcpSessionEntryMock = vi.hoisted(() => vi.fn());
@@ -65,6 +66,15 @@ async function flushMicrotasks(): Promise<void> {
   await new Promise<void>((resolve) => queueMicrotask(resolve));
 }
 
+describe("telegram thread binding placement", () => {
+  it("keeps loaded plugin placement aligned with the bundled public artifact", async () => {
+    const api = await import("../thread-binding-api.js");
+
+    expect(telegramPlugin.conversationBindings?.defaultTopLevelPlacement).toBe("child");
+    expect(api.defaultTopLevelPlacement).toBe("child");
+  });
+});
+
 describe("telegram thread bindings", () => {
   const originalStateDir = process.env.OPENCLAW_STATE_DIR;
   let stateDirOverride: string | undefined;
diff --git a/src/agents/sessions-spawn-hooks.test.ts b/src/agents/sessions-spawn-hooks.test.ts
@@ -5,6 +5,19 @@ import {
 } from "./subagent-spawn.test-helpers.js";
 
 type GatewayRequest = { method?: string; params?: Record<string, unknown> };
+type TestSubagentSpawningResult =
+  | undefined
+  | { status: "error"; error: string }
+  | {
+      status: "ok";
+      threadBindingReady: boolean;
+      deliveryOrigin?: {
+        channel: string;
+        to: string;
+        accountId?: string;
+        threadId?: string;
+      };
+    };
 
 const hoisted = vi.hoisted(() => ({
   callGatewayMock: vi.fn(),
@@ -14,7 +27,7 @@ const hoisted = vi.hoisted(() => ({
 
 const hookRunnerMocks = vi.hoisted(() => ({
   hasSubagentEndedHook: true,
-  runSubagentSpawning: vi.fn(async (event: unknown) => {
+  runSubagentSpawning: vi.fn(async (event: unknown): Promise<TestSubagentSpawningResult> => {
     const input = event as {
       threadRequested?: boolean;
       requester?: { channel?: string };
diff --git a/src/agents/subagent-spawn.ts b/src/agents/subagent-spawn.ts
@@ -698,7 +698,7 @@ function resolveBoundThreadDeliveryOrigin(params: {
 }): DeliveryContext | undefined {
   const bindings = getSessionBindingService()
     .listBySession(params.childSessionKey)
-    .filter((binding) => binding.status !== "inactive");
+    .filter((binding) => binding.status === "active");
   for (const binding of bindings) {
     const conversation = binding.conversation;
     if (!conversation.parentConversationId) {
