fix(models): bypass replace mode check when browsing and resolve default list leak

aniruddhaadak80 · aniruddhaadak80 · commit fe51174b8055 · 2026-06-28T18:11:39.000+05:30
diff --git a/src/commands/models/list.list-command.ts b/src/commands/models/list.list-command.ts
@@ -175,6 +175,7 @@ export async function modelsListCommand(
       provider: providerFilter,
       local: opts.local,
     },
+    browse: enableSourcePlanCascade,
     skipRuntimeModelSuppression,
     metadataSnapshot,
     workspaceDir,
diff --git a/src/commands/models/list.rows.test.ts b/src/commands/models/list.rows.test.ts
@@ -248,6 +248,65 @@ describe("appendProviderCatalogRows", () => {
     expect(rows).toHaveLength(1);
     expect(rows[0].key).toBe("xai/grok-4");
   });
+
+  it("does not filter out providers when mode is replace but browse is true", async () => {
+    const rows: ModelRow[] = [];
+
+    await appendProviderCatalogRows({
+      rows,
+      seenKeys: new Set(),
+      catalogModels: [
+        {
+          id: "gpt-5.5",
+          name: "gpt-5.5",
+          provider: "openai",
+          api: "openai-responses",
+          baseUrl: "https://api.openai.com/v1",
+          input: ["text"],
+          reasoning: false,
+          cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
+          contextWindow: 8192,
+          maxTokens: 4096,
+        },
+        {
+          id: "grok-4",
+          name: "grok-4",
+          provider: "xai",
+          api: "xai-responses",
+          baseUrl: "https://api.xai.com/v1",
+          input: ["text"],
+          reasoning: false,
+          cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
+          contextWindow: 8192,
+          maxTokens: 4096,
+        },
+      ],
+      context: {
+        cfg: {
+          models: {
+            mode: "replace",
+            providers: {
+              xai: {},
+            },
+          },
+        },
+        agentDir: "/tmp/openclaw-agent",
+        authIndex: {
+          hasProviderAuth: () => true,
+          allowsProviderAuthAvailabilityFallback: () => false,
+        },
+        configuredByKey: new Map(),
+        discoveredKeys: new Set(),
+        filter: { local: false },
+        browse: true,
+        skipRuntimeModelSuppression: true,
+      },
+    });
+
+    expect(rows).toHaveLength(2);
+    expect(rows[0].key).toBe("openai/gpt-5.5");
+    expect(rows[1].key).toBe("xai/grok-4");
+  });
 });
 
 describe("appendConfiguredProviderRows", () => {
diff --git a/src/commands/models/list.rows.ts b/src/commands/models/list.rows.ts
@@ -41,6 +41,7 @@ export type RowBuilderContext = {
   configuredByKey: ConfiguredByKey;
   discoveredKeys: Set<string>;
   filter: RowFilter;
+  browse?: boolean;
   skipRuntimeModelSuppression?: boolean;
   metadataSnapshot?: PluginMetadataSnapshot;
   workspaceDir?: string;
@@ -81,6 +82,9 @@ function matchesProviderFilter(context: RowBuilderContext, provider: string): bo
 }
 
 function isProviderAllowed(context: RowBuilderContext, provider: string): boolean {
+  if (context.browse) {
+    return true;
+  }
   if (context.cfg.models?.mode !== "replace") {
     return true;
   }
@@ -411,6 +415,9 @@ export async function appendAuthenticatedCatalogRows(params: {
     metadataSnapshot: params.context.metadataSnapshot,
   });
   for (const entry of catalog) {
+    if (!isProviderAllowed(params.context, entry.provider)) {
+      continue;
+    }
     if (!params.context.authIndex.hasProviderAuth(entry.provider)) {
       continue;
     }
