test: tighten malformed secrets plan proof

steipete · krissding · web-flow · commit fcdc48d47a65 · 2026-07-17T01:52:10.000-07:00
Co-authored-by: 丁宇婷0668001435 &lt;ding.yuting@xydigit.com&gt;
diff --git a/src/cli/secrets-cli.test.ts b/src/cli/secrets-cli.test.ts
@@ -125,12 +125,15 @@ function createSecretsApplyResult(options?: {
   };
 }
 
-async function withPlanFile(run: (planPath: string) => Promise<void>) {
+async function withPlanFile(
+  run: (planPath: string) => Promise<void>,
+  contents = `${JSON.stringify(createManualSecretsPlan())}\n`,
+) {
   const planPath = path.join(
     os.tmpdir(),
     `openclaw-secrets-cli-test-${Date.now()}-${Math.random().toString(16).slice(2)}.json`,
   );
-  await fs.writeFile(planPath, `${JSON.stringify(createManualSecretsPlan())}\n`, "utf8");
+  await fs.writeFile(planPath, contents, "utf8");
   try {
     await run(planPath);
   } finally {
@@ -386,19 +389,14 @@ describe("secrets CLI", () => {
   });
 
   it("shows a user-friendly error when the secrets plan file is malformed JSON", async () => {
-    const planPath = path.join(
-      os.tmpdir(),
-      `openclaw-secrets-cli-test-${Date.now()}-${Math.random().toString(16).slice(2)}.json`,
-    );
-    await fs.writeFile(planPath, "{invalid json", "utf8");
-    try {
-      await createProgram().parseAsync(["secrets", "apply", "--from", planPath], { from: "user" });
-    } catch {
-      // exitOverride converts exit(1) to CommanderError
-    }
-    expect(defaultRuntime.error).toHaveBeenCalledWith(
-      expect.stringContaining("Malformed JSON in secrets plan file:"),
-    );
+    await withPlanFile(async (planPath) => {
+      await expect(
+        createProgram().parseAsync(["secrets", "apply", "--from", planPath], { from: "user" }),
+      ).rejects.toThrow("__exit__:1");
+
+      expect(runtimeErrors.at(-1)).toContain(`Malformed JSON in secrets plan file: ${planPath}`);
+      expect(runSecretsApply).not.toHaveBeenCalled();
+    }, "{invalid json");
   });
 
   it("does not print skipped-exec note when apply dry-run skippedExecRefs is zero", async () => {
