fix: extend resolveCacheRetention to pass through cacheRetention for amazon-bedrock

snese · snese · commit fb85a4d58e6b · 2026-02-21T08:55:44.000+08:00
The runtime resolveCacheRetention hard-gates on provider === "anthropic" and returns undefined for amazon-bedrock, so cacheRetention set in model params is never consumed at runtime for Bedrock models. Extend the gate to also accept amazon-bedrock when cacheRetention is explicitly configured. No default is applied for Bedrock since pi-ai own provider already defaults to "short" internally. Refs #21986
diff --git a/src/agents/pi-embedded-runner/extra-params.ts b/src/agents/pi-embedded-runner/extra-params.ts
@@ -42,16 +42,20 @@ type CacheRetentionStreamOptions = Partial<SimpleStreamOptions> & {
  *
  * Mapping: "5m" → "short", "1h" → "long"
  *
- * Only applies to Anthropic provider (OpenRouter uses openai-completions API
- * with hardcoded cache_control, not the cacheRetention stream option).
+ * Only applies to Anthropic provider and Anthropic Claude models on Bedrock.
+ * (OpenRouter uses openai-completions API with hardcoded cache_control,
+ * not the cacheRetention stream option).
  *
- * Defaults to "short" for Anthropic provider when not explicitly configured.
+ * Defaults to "short" for Anthropic when not explicitly configured.
  */
 function resolveCacheRetention(
   extraParams: Record<string, unknown> | undefined,
   provider: string,
 ): CacheRetention | undefined {
-  if (provider !== "anthropic") {
+  const isAnthropicDirect = provider === "anthropic";
+  const isAnthropicBedrock =
+    provider === "amazon-bedrock" && extraParams?.cacheRetention !== undefined;
+  if (!isAnthropicDirect && !isAnthropicBedrock) {
     return undefined;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -42,16 +42,20 @@ type CacheRetentionStreamOptions = Partial<SimpleStreamOptions> & {`
`42`	`42`	`*`
`43`	`43`	`* Mapping: "5m" → "short", "1h" → "long"`
`44`	`44`	`*`
`45`		`- * Only applies to Anthropic provider (OpenRouter uses openai-completions API`
`46`		`- * with hardcoded cache_control, not the cacheRetention stream option).`
	`45`	`+ * Only applies to Anthropic provider and Anthropic Claude models on Bedrock.`
	`46`	`+ * (OpenRouter uses openai-completions API with hardcoded cache_control,`
	`47`	`+ * not the cacheRetention stream option).`
`47`	`48`	`*`
`48`		`- * Defaults to "short" for Anthropic provider when not explicitly configured.`
	`49`	`+ * Defaults to "short" for Anthropic when not explicitly configured.`
`49`	`50`	`*/`
`50`	`51`	`function resolveCacheRetention(`
`51`	`52`	`extraParams: Record<string, unknown> \| undefined,`
`52`	`53`	`provider: string,`
`53`	`54`	`): CacheRetention \| undefined {`
`54`		`- if (provider !== "anthropic") {`
	`55`	`+ const isAnthropicDirect = provider === "anthropic";`
	`56`	`+ const isAnthropicBedrock =`
	`57`	`+ provider === "amazon-bedrock" && extraParams?.cacheRetention !== undefined;`
	`58`	`+ if (!isAnthropicDirect && !isAnthropicBedrock) {`
`55`	`59`	`return undefined;`
`56`	`60`	`}`
`57`	`61`