fix(qa-lab): use junctions for Windows workspace repo links

vincentkoc · vincentkoc · commit fb022a2b07cb · 2026-06-20T08:39:32.000+02:00
diff --git a/extensions/qa-lab/src/qa-agent-workspace.test.ts b/extensions/qa-lab/src/qa-agent-workspace.test.ts
@@ -2,14 +2,20 @@
 import fs from "node:fs/promises";
 import path from "node:path";
 import { afterEach, describe, expect, it } from "vitest";
-import { seedQaAgentWorkspace } from "./qa-agent-workspace.js";
+import { __testing, seedQaAgentWorkspace } from "./qa-agent-workspace.js";
 import { createTempDirHarness } from "./temp-dir.test-helper.js";
 
 const { cleanup, makeTempDir } = createTempDirHarness();
 
 afterEach(cleanup);
 
 describe("seedQaAgentWorkspace", () => {
+  it("uses Windows junctions for the repo link", () => {
+    expect(__testing.resolveQaAgentWorkspaceRepoLinkType("win32")).toBe("junction");
+    expect(__testing.resolveQaAgentWorkspaceRepoLinkType("linux")).toBe("dir");
+    expect(__testing.resolveQaAgentWorkspaceRepoLinkType("darwin")).toBe("dir");
+  });
+
   it("creates a repo symlink when a repo root is provided", async () => {
     const workspaceDir = await makeTempDir("qa-workspace-");
     const repoRoot = await makeTempDir("qa-repo-");
diff --git a/extensions/qa-lab/src/qa-agent-workspace.ts b/extensions/qa-lab/src/qa-agent-workspace.ts
@@ -7,6 +7,10 @@ import {
   readQaScenarioPackYamlSource,
 } from "./scenario-catalog.js";
 
+function resolveQaAgentWorkspaceRepoLinkType(platform: NodeJS.Platform = process.platform) {
+  return platform === "win32" ? "junction" : "dir";
+}
+
 export async function seedQaAgentWorkspace(params: { workspaceDir: string; repoRoot?: string }) {
   const catalog = readQaBootstrapScenarioCatalog();
   await fs.mkdir(params.workspaceDir, { recursive: true });
@@ -44,6 +48,12 @@ The mounted repo source should be available read-only under \`./repo/\`.
   if (params.repoRoot) {
     const repoLinkPath = path.join(params.workspaceDir, "repo");
     await fs.rm(repoLinkPath, { force: true, recursive: true });
-    await fs.symlink(params.repoRoot, repoLinkPath, "dir");
+    await fs.symlink(params.repoRoot, repoLinkPath, resolveQaAgentWorkspaceRepoLinkType());
   }
 }
+
+const testing = {
+  resolveQaAgentWorkspaceRepoLinkType,
+};
+
+export { testing as __testing };
