fix(cron): keep bounded diagnostics UTF-16 safe (#102624)

lzyyzznl · steipete · web-flow · commit f786efddcd88 · 2026-07-09T13:05:51.000+01:00
* fix(cron): use truncateUtf16Safe for diagnostic entry and summary truncation

* test(cron): cover UTF-16 diagnostic boundaries

---------

Co-authored-by: Peter Steinberger &lt;steipete@gmail.com&gt;
diff --git a/src/cron/run-diagnostics.test.ts b/src/cron/run-diagnostics.test.ts
@@ -31,6 +31,29 @@ describe("cron run diagnostics", () => {
     expect(diagnostics?.summary).toHaveLength(2_000);
   });
 
+  it("keeps bounded diagnostic text valid at UTF-16 boundaries", () => {
+    const diagnostics = normalizeCronRunDiagnostics({
+      summary: `${"s".repeat(1_998)}😀tail`,
+      entries: [
+        {
+          ts: 1,
+          source: "exec",
+          severity: "error",
+          message: `${"m".repeat(998)}😀tail`,
+        },
+      ],
+    });
+
+    expect(diagnostics?.summary).toBe(`${"s".repeat(1_998)}…`);
+    expect(diagnostics?.entries[0]).toEqual({
+      ts: 1,
+      source: "exec",
+      severity: "error",
+      message: `${"m".repeat(998)}…`,
+      truncated: true,
+    });
+  });
+
   it("preserves later terminal diagnostics when capping entries", () => {
     const diagnostics = normalizeCronRunDiagnostics({
       entries: [
diff --git a/src/cron/run-diagnostics.ts b/src/cron/run-diagnostics.ts
@@ -1,5 +1,6 @@
 /** Builds bounded, redacted diagnostics for cron run logs and UI surfaces. */
 import { normalizeOptionalString } from "@openclaw/normalization-core/string-coerce";
+import { truncateUtf16Safe } from "@openclaw/normalization-core/utf16-slice";
 import { isToolAllowedByPolicyName } from "../agents/tool-policy-match.js";
 import { normalizeToolName as normalizePolicyToolName } from "../agents/tool-policy.js";
 import { getReplyPayloadMetadata } from "../auto-reply/reply-payload.js";
@@ -101,7 +102,7 @@ function normalizeDiagnosticMessage(value: unknown): { message?: string; truncat
   if (redacted.length <= MAX_ENTRY_CHARS) {
     return { message: redacted };
   }
-  return { message: `${redacted.slice(0, MAX_ENTRY_CHARS - 1)}…`, truncated: true };
+  return { message: `${truncateUtf16Safe(redacted, MAX_ENTRY_CHARS - 1)}…`, truncated: true };
 }
 
 function trimSummary(value: string | undefined): string | undefined {
@@ -112,7 +113,7 @@ function trimSummary(value: string | undefined): string | undefined {
   if (normalized.length <= MAX_SUMMARY_CHARS) {
     return normalized;
   }
-  return `${normalized.slice(0, MAX_SUMMARY_CHARS - 1)}…`;
+  return `${truncateUtf16Safe(normalized, MAX_SUMMARY_CHARS - 1)}…`;
 }
 
 /** Returns the operator-facing summary for persisted cron diagnostics. */

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`/** Builds bounded, redacted diagnostics for cron run logs and UI surfaces. */`
`2`	`2`	`import { normalizeOptionalString } from "@openclaw/normalization-core/string-coerce";`
	`3`	`+import { truncateUtf16Safe } from "@openclaw/normalization-core/utf16-slice";`
`3`	`4`	`import { isToolAllowedByPolicyName } from "../agents/tool-policy-match.js";`
`4`	`5`	`import { normalizeToolName as normalizePolicyToolName } from "../agents/tool-policy.js";`
`5`	`6`	`import { getReplyPayloadMetadata } from "../auto-reply/reply-payload.js";`
`@@ -101,7 +102,7 @@ function normalizeDiagnosticMessage(value: unknown): { message?: string; truncat`
`101`	`102`	`if (redacted.length <= MAX_ENTRY_CHARS) {`
`102`	`103`	`return { message: redacted };`
`103`	`104`	`}`
`104`		- return { message: `${redacted.slice(0, MAX_ENTRY_CHARS - 1)}…`, truncated: true };
	`105`	+ return { message: `${truncateUtf16Safe(redacted, MAX_ENTRY_CHARS - 1)}…`, truncated: true };
`105`	`106`	`}`
`106`	`107`
`107`	`108`	`function trimSummary(value: string \| undefined): string \| undefined {`
`@@ -112,7 +113,7 @@ function trimSummary(value: string \| undefined): string \| undefined {`
`112`	`113`	`if (normalized.length <= MAX_SUMMARY_CHARS) {`
`113`	`114`	`return normalized;`
`114`	`115`	`}`
`115`		- return `${normalized.slice(0, MAX_SUMMARY_CHARS - 1)}…`;
	`116`	+ return `${truncateUtf16Safe(normalized, MAX_SUMMARY_CHARS - 1)}…`;
`116`	`117`	`}`
`117`	`118`
`118`	`119`	`/** Returns the operator-facing summary for persisted cron diagnostics. */`