fix(feishu): re-throw unresolved SecretRef errors from media fallbacks

Bartok9 · Bartok9 · commit f5b4600776e9 · 2026-06-02T04:00:38.000-05:00
Previously, both catch blocks in feishuOutbound.sendText (local-image auto-convert path) and feishuOutbound.sendMedia silently swallowed all errors, including FeishuSecretRefUnavailableError. When appSecret (or another credential) was configured with an exec/file/keychain SecretRef that had not been pre-resolved by the gateway, the error was caught and the send degraded to a plain-text URL link with only a console.error, giving the caller no indication that credentials were missing. Re-throw FeishuSecretRefUnavailableError in both catch blocks so the configuration error surfaces immediately instead of being masked by the fallback path. Two new tests in outbound.test.ts cover both catch sites. Fixes #89338
diff --git a/extensions/feishu/src/outbound.test.ts b/extensions/feishu/src/outbound.test.ts
@@ -72,6 +72,7 @@ vi.mock("./comment-reaction.js", () => ({
   cleanupAmbientCommentTypingReaction: cleanupAmbientCommentTypingReactionMock,
 }));
 
+import { FeishuSecretRefUnavailableError } from "./accounts.js";
 import { feishuPlugin } from "./channel.js";
 import { feishuOutbound } from "./outbound.js";
 import { createFeishuSendReceipt } from "./send-result.js";
@@ -343,6 +344,30 @@ describe("feishuOutbound.sendText local-image auto-convert", () => {
     }
   });
 
+  it("propagates FeishuSecretRefUnavailableError from local-image path instead of silently falling back", async () => {
+    const { dir, file } = await createTmpImage();
+    const secretRefError = new FeishuSecretRefUnavailableError(
+      "channels.feishu.accounts.main.appSecret",
+      { source: "exec", provider: "keychain_feishu_main", id: "value" },
+    );
+    sendMediaFeishuMock.mockRejectedValueOnce(secretRefError);
+    try {
+      await expect(
+        sendText({
+          cfg: emptyConfig,
+          to: "chat_1",
+          text: file,
+          accountId: "main",
+        }),
+      ).rejects.toBeInstanceOf(FeishuSecretRefUnavailableError);
+
+      // Must NOT have silently fallen back to a text send.
+      expect(sendMessageFeishuMock).not.toHaveBeenCalled();
+    } finally {
+      await fs.rm(dir, { recursive: true, force: true });
+    }
+  });
+
   it("uses markdown cards when renderMode=card", async () => {
     const result = await sendText({
       cfg: cardRenderConfig,
@@ -1206,6 +1231,30 @@ describe("feishuOutbound.sendMedia replyToId forwarding", () => {
 
     expect(sendMessageCall()?.replyToMessageId).toBe("om_reply_target");
   });
+
+  it("propagates FeishuSecretRefUnavailableError from sendMedia instead of silently falling back", async () => {
+    // Simulate an unresolved SecretRef reaching the media upload path.
+    // This happens when the gateway has not pre-resolved an exec/file/keychain
+    // SecretRef at action dispatch time (issue #89338).
+    const secretRefError = new FeishuSecretRefUnavailableError(
+      "channels.feishu.accounts.main.appSecret",
+      { source: "exec", provider: "keychain_feishu_main", id: "value" },
+    );
+    sendMediaFeishuMock.mockRejectedValueOnce(secretRefError);
+
+    await expect(
+      feishuOutbound.sendMedia?.({
+        cfg: emptyConfig,
+        to: "chat_1",
+        text: "here is the image",
+        mediaUrl: "https://example.com/image.png",
+        accountId: "main",
+      }),
+    ).rejects.toBeInstanceOf(FeishuSecretRefUnavailableError);
+
+    // Must NOT have silently fallen back to a text send.
+    expect(sendMessageFeishuMock).not.toHaveBeenCalled();
+  });
 });
 
 describe("feishuOutbound.sendMedia renderMode", () => {
