refactor(tailscale): split status retry helper

TUARAN · TUARAN · commit f58e6810fa4d · 2026-07-13T14:36:57.000+08:00
diff --git a/src/infra/tailscale.ts b/src/infra/tailscale.ts
@@ -1,6 +1,5 @@
 // Integrates with the local Tailscale CLI for tailnet setup and sharing.
 import { existsSync } from "node:fs";
-import { setTimeout as delay } from "node:timers/promises";
 import {
   asDateTimestampMs,
   resolveExpiresAtMsFromDurationMs,
@@ -13,6 +12,7 @@ import {
 import { logVerbose } from "../globals.js";
 import { runExec } from "../process/exec.js";
 import { toErrorObject } from "./errors.js";
+import { readTailscaleStatusJson } from "./tailscale-status.js";
 
 function parsePossiblyNoisyJsonObject(stdout: string): Record<string, unknown> {
   const trimmed = stdout.trim();
@@ -24,54 +24,6 @@ function parsePossiblyNoisyJsonObject(stdout: string): Record<string, unknown> {
   return JSON.parse(trimmed) as Record<string, unknown>;
 }
 
-const TAILSCALE_STATUS_ATTEMPTS = 3;
-const TAILSCALE_STATUS_RETRY_DELAY_MS = 500;
-
-function isTransientTailscaleStatusError(error: unknown): boolean {
-  const record = readRecord(error);
-  const timedOut = record?.killed === true && record.signal === "SIGTERM";
-  const detail = [
-    error instanceof Error ? error.message : undefined,
-    typeof record?.stderr === "string" ? record.stderr : undefined,
-    typeof record?.stdout === "string" ? record.stdout : undefined,
-  ]
-    .filter((value): value is string => Boolean(value))
-    .join("\n")
-    .toLowerCase();
-
-  return (
-    timedOut ||
-    detail.includes("failed to connect to local tailscale") ||
-    detail.includes("connection refused") ||
-    detail.includes("503 service unavailable: no backend")
-  );
-}
-
-async function readTailscaleStatusJson(
-  candidate: string,
-  exec: typeof runExec,
-): Promise<Record<string, unknown>> {
-  for (let attempt = 1; attempt <= TAILSCALE_STATUS_ATTEMPTS; attempt += 1) {
-    let stdout: string;
-    try {
-      ({ stdout } = await exec(candidate, ["status", "--json"], {
-        timeoutMs: 5000,
-        maxBuffer: 400_000,
-      }));
-    } catch (error) {
-      if (!isTransientTailscaleStatusError(error) || attempt === TAILSCALE_STATUS_ATTEMPTS) {
-        throw toErrorObject(error, "Non-Error thrown");
-      }
-      // Serve startup can briefly race daemon status. Retry the same detected binary so
-      // binary fallback does not hide the transient failure or change installations.
-      await delay(TAILSCALE_STATUS_RETRY_DELAY_MS);
-      continue;
-    }
-    return stdout ? parsePossiblyNoisyJsonObject(stdout) : {};
-  }
-  throw new Error("Tailscale status retry loop exhausted");
-}
-
 /**
  * Locate Tailscale binary using multiple strategies:
  * 1. PATH lookup (via which command)
@@ -179,7 +131,7 @@ export async function getTailnetHostname(exec: typeof runExec = runExec, detecte
       continue;
     }
     try {
-      const parsed = await readTailscaleStatusJson(candidate, exec);
+      const parsed = await readTailscaleStatusJson(candidate, exec, parsePossiblyNoisyJsonObject);
       const self =
         typeof parsed.Self === "object" && parsed.Self !== null
           ? (parsed.Self as Record<string, unknown>)
