fix(active-memory): match inherited missing memory tool errors

Takhoffman · Takhoffman · commit f383456c9a2f · 2026-05-04T16:33:05.000-05:00
diff --git a/extensions/active-memory/index.test.ts b/extensions/active-memory/index.test.ts
@@ -125,10 +125,13 @@ describe("active-memory plugin", () => {
       "utf8",
     );
   };
-  const makeMemoryToolAllowlistError = (reason: string) =>
+  const makeMemoryToolAllowlistError = (
+    reason: string,
+    sources = "runtime toolsAllow: memory_recall, memory_search, memory_get",
+  ) =>
     new Error(
       `No callable tools remain after resolving explicit tool allowlist ` +
-        `(runtime toolsAllow: memory_recall, memory_search, memory_get); ${reason}. ` +
+        `(${sources}); ${reason}. ` +
         `Fix the allowlist or enable the plugin that registers the requested tool.`,
     );
   const hasDebugLine = (needle: string) =>
@@ -1683,6 +1686,32 @@ describe("active-memory plugin", () => {
     expect(lines.join("\n")).not.toContain("status=unavailable");
   });
 
+  it("skips missing memory tools when the allowlist error includes inherited sources", async () => {
+    const sessionKey = "agent:main:missing-memory-tools-with-policy-source";
+    hoisted.sessionStore[sessionKey] = {
+      sessionId: "s-missing-memory-tools-with-policy-source",
+      updatedAt: 0,
+    };
+    const error = makeMemoryToolAllowlistError(
+      "no registered tools matched",
+      "tools.allow: *, lobster; runtime toolsAllow: memory_recall, memory_search, memory_get",
+    );
+    expect(__testing.isMissingRegisteredMemoryToolsError(error)).toBe(true);
+    runEmbeddedPiAgent.mockRejectedValueOnce(error);
+
+    const result = await hooks.before_prompt_build(
+      { prompt: "what wings should i order? missing memory tools with policy", messages: [] },
+      { agentId: "main", trigger: "user", sessionKey, messageProvider: "webchat" },
+    );
+
+    expect(result).toBeUndefined();
+    expect(hasDebugLine("no memory tools registered")).toBe(true);
+    expect(hasWarnLine("No callable tools remain")).toBe(false);
+    expect(getActiveMemoryLines(sessionKey)).toEqual([
+      expect.stringContaining("🧩 Active Memory: status=empty"),
+    ]);
+  });
+
   it.each([
     ["disabled tools", "tools are disabled for this run"],
     ["models without tool support", "the selected model does not support tools"],
diff --git a/extensions/active-memory/index.ts b/extensions/active-memory/index.ts
@@ -42,10 +42,6 @@ const DEFAULT_TRANSCRIPT_DIR = "active-memory";
 const DEFAULT_CIRCUIT_BREAKER_MAX_TIMEOUTS = 3;
 const DEFAULT_CIRCUIT_BREAKER_COOLDOWN_MS = 60_000;
 const ACTIVE_MEMORY_TOOL_ALLOWLIST = ["memory_recall", "memory_search", "memory_get"] as const;
-const MISSING_REGISTERED_MEMORY_TOOLS_ERROR_MESSAGE =
-  `No callable tools remain after resolving explicit tool allowlist (` +
-  `runtime toolsAllow: ${ACTIVE_MEMORY_TOOL_ALLOWLIST.join(", ")}` +
-  `); no registered tools matched. Fix the allowlist or enable the plugin that registers the requested tool.`;
 const TOGGLE_STATE_FILE = "session-toggles.json";
 const DEFAULT_PARTIAL_TRANSCRIPT_MAX_CHARS = 32_000;
 const DEFAULT_TRANSCRIPT_READ_MAX_LINES = 2_000;
@@ -500,8 +496,15 @@ function normalizeOptionalString(value: unknown): string | undefined {
 }
 
 function isMissingRegisteredMemoryToolsError(error: unknown): boolean {
+  if (!(error instanceof Error)) {
+    return false;
+  }
+  const message = error.message.trim();
   return (
-    error instanceof Error && error.message.trim() === MISSING_REGISTERED_MEMORY_TOOLS_ERROR_MESSAGE
+    message.startsWith("No callable tools remain after resolving explicit tool allowlist (") &&
+    message.includes(`runtime toolsAllow: ${ACTIVE_MEMORY_TOOL_ALLOWLIST.join(", ")}`) &&
+    message.includes("; no registered tools matched.") &&
+    message.endsWith("Fix the allowlist or enable the plugin that registers the requested tool.")
   );
 }
 
