fix(feishu): omit both replyToMessageId and rootId from streaming.start() in DM chats

ZOOWH · ZOOWH · commit f20073aa086f · 2026-06-20T07:54:27.000+08:00
In DM chats (skipReplyToInMessages=true), the streaming card start() previously received the raw replyToMessageId and rootId, causing resolveStreamingCardSendMode to choose "reply" or "root_create" mode instead of "create". This mismatched the behavior of plain-text and static-card sends, which omit reply metadata in DMs. - Pass sendReplyToMessageId (already undefined in DM) to streaming.start() - Add streamingRootId: undefined in DM (skipReplyToInMessages=true), preserving rootId for group/thread streaming - Add regression tests for DM (both fields omitted) and group (both preserved) streaming card send modes Closes #94922
diff --git a/extensions/feishu/src/reply-dispatcher.test.ts b/extensions/feishu/src/reply-dispatcher.test.ts
@@ -1565,25 +1565,46 @@ describe("createFeishuReplyDispatcher streaming behavior", () => {
     });
   });
 
-  it("omits replyToMessageId from streaming.start() in DM chats (skipReplyToInMessages)", async () => {
-    // In DM chats, skipReplyToInMessages=true means sendReplyToMessageId=undefined.
-    // The streaming card start() should receive undefined replyToMessageId,
-    // so resolveStreamingCardSendMode returns "create" (no Reply-to label in DM).
+  it("omits both replyToMessageId and rootId from streaming.start() in DM chats (skipReplyToInMessages)", async () => {
+    // In DM chats, skipReplyToInMessages=true means both sendReplyToMessageId and
+    // streamingRootId are undefined. The streaming card start() should receive
+    // undefined for both, so resolveStreamingCardSendMode returns "create" (no
+    // Reply-to label, no root_create fallback in DM).
     const { options } = createDispatcherHarness({
       runtime: createRuntimeLogger(),
-      replyToMessageId: "om_dm_msg",
+      replyToMessageId: "dm_msg",
       skipReplyToInMessages: true,
+      rootId: "dm_root",
     });
     await options.deliver({ text: "```ts\nconst x = 1\n```" }, { kind: "final" });
 
     expect(streamingInstances).toHaveLength(1);
     expectStreamingStartOptions(0, {
       replyToMessageId: undefined,
+      rootId: undefined,
       header: { title: "agent", template: "blue" },
       note: "Agent: agent",
     });
   });
 
+  it("preserves rootId for group/thread streaming when skipReplyToInMessages is false", async () => {
+    // In group chats, skipReplyToInMessages=false so rootId is passed through,
+    // enabling root_create mode for proper threading.
+    const { options } = createDispatcherHarness({
+      runtime: createRuntimeLogger(),
+      replyToMessageId: "group_msg",
+      skipReplyToInMessages: false,
+      rootId: "group_root",
+    });
+    await options.deliver({ text: "```ts\nconst x = 1\n```" }, { kind: "final" });
+
+    expect(streamingInstances).toHaveLength(1);
+    expectStreamingStartOptions(0, {
+      replyToMessageId: "group_msg",
+      rootId: "group_root",
+    });
+  });
+
   it("uses streaming cards for thread replies and keeps topic metadata", async () => {
     const { options } = createDispatcherHarness({
       runtime: createRuntimeLogger(),
diff --git a/extensions/feishu/src/reply-dispatcher.ts b/extensions/feishu/src/reply-dispatcher.ts
@@ -171,6 +171,10 @@ export function createFeishuReplyDispatcher(params: CreateFeishuReplyDispatcherP
     mentionTargets,
   } = params;
   const sendReplyToMessageId = skipReplyToInMessages ? undefined : replyToMessageId;
+  // In DM chats (skipReplyToInMessages=true), ordinary DM rootId should also be
+  // omitted so streaming.start() chooses "create" mode, matching plain-text and
+  // static-card sends. Group/thread rootId is preserved for correct threading.
+  const streamingRootId = skipReplyToInMessages ? undefined : rootId;
   const typingTargetMessageId = explicitTypingTargetMessageId?.trim() || replyToMessageId;
   const threadReplyMode = threadReply === true;
   const effectiveReplyInThread = threadReplyMode ? true : replyInThread;
@@ -394,7 +398,7 @@ export function createFeishuReplyDispatcher(params: CreateFeishuReplyDispatcherP
         await streaming.start(chatId, resolveReceiveIdType(chatId), {
           replyToMessageId: sendReplyToMessageId,
           replyInThread: effectiveReplyInThread,
-          rootId,
+          rootId: streamingRootId,
           header: cardHeader,
           note: cardNote,
         });
