fix(memory-core): suppress WARN for narrative cleanup scope errors

1aifanatic · 1aifanatic · commit f01d580fcd0d · 2026-04-17T17:47:40.000-05:00
deleteSession during dreaming cleanup fails with "missing scope:
operator.admin" when the cron session lacks admin permissions.
This is expected best-effort behavior, but logged at WARN, which floods
logs after every dreaming cycle.

Downgrade to debug when the error matches /missing scopes?:/i.
Also add optional debug field to the Logger type so callers without
a debug method (like dreaming-phases) compile cleanly.
diff --git a/extensions/memory-core/src/dreaming-narrative.test.ts b/extensions/memory-core/src/dreaming-narrative.test.ts
@@ -573,6 +573,7 @@ describe("generateAndAppendDreamNarrative", () => {
 
   function createMockLogger() {
     return {
+      debug: vi.fn(),
       info: vi.fn(),
       warn: vi.fn(),
       error: vi.fn(),
@@ -678,6 +679,27 @@ describe("generateAndAppendDreamNarrative", () => {
     );
   });
 
+  it("logs debug (not warn) when deleteSession fails due to missing scope", async () => {
+    const workspaceDir = await createTempWorkspace("openclaw-dreaming-narrative-");
+    const subagent = createMockSubagent("");
+    subagent.deleteSession.mockRejectedValue(new Error("missing scope: operator.admin"));
+    const logger = createMockLogger();
+
+    await generateAndAppendDreamNarrative({
+      subagent,
+      workspaceDir,
+      data: { phase: "light", snippets: ["some memory"] },
+      logger,
+    });
+
+    expect(logger.warn).not.toHaveBeenCalledWith(
+      expect.stringContaining("narrative session cleanup failed"),
+    );
+    expect(logger.debug).toHaveBeenCalledWith(
+      expect.stringContaining("narrative session cleanup skipped for light phase"),
+    );
+  });
+
   it("handles subagent error gracefully", async () => {
     const workspaceDir = await createTempWorkspace("openclaw-dreaming-narrative-");
     const subagent = createMockSubagent("");
diff --git a/extensions/memory-core/src/dreaming-narrative.ts b/extensions/memory-core/src/dreaming-narrative.ts
@@ -51,6 +51,7 @@ export type NarrativePhaseData = {
 };
 
 type Logger = {
+  debug?: (message: string) => void;
   info: (message: string) => void;
   warn: (message: string) => void;
   error: (message: string) => void;
@@ -932,9 +933,18 @@ export async function generateAndAppendDreamNarrative(params: {
     try {
       await params.subagent.deleteSession({ sessionKey });
     } catch (cleanupErr) {
-      params.logger.warn(
-        `memory-core: narrative session cleanup failed for ${params.data.phase} phase: ${formatErrorMessage(cleanupErr)}`,
-      );
+      const errMsg = formatErrorMessage(cleanupErr);
+      // Cleanup is best-effort; permission errors are expected when the cron
+      // session lacks operator.admin scope — log at debug to avoid noise.
+      if (/missing scopes?:/i.test(errMsg)) {
+        params.logger.debug?.(
+          `memory-core: narrative session cleanup skipped for ${params.data.phase} phase (insufficient scope): ${errMsg}`,
+        );
+      } else {
+        params.logger.warn(
+          `memory-core: narrative session cleanup failed for ${params.data.phase} phase: ${errMsg}`,
+        );
+      }
     }
 
     await scrubDreamingNarrativeArtifacts(params.logger).catch((scrubErr: unknown) => {
