fix(ui): read exec security from tools config

steipete · steipete · commit ec4b6ab26241 · 2026-05-08T04:04:22.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -163,6 +163,7 @@ Docs: https://docs.openclaw.ai
 
 ### Fixes
 
+- Control UI/settings: show the active `tools.exec.security` policy in Quick Settings instead of stale agent-default exec security.
 - Gateway/watch: leave `OPENCLAW_TRACE_SYNC_IO` disabled by default in `pnpm gateway:watch:raw` so watch mode avoids noisy Node sync-I/O stack traces unless explicitly requested.
 - Codex app-server: close stdio stdin before force-killing the managed app-server, matching Codex single-client shutdown behavior and avoiding unsettled CLI exits after successful runs.
 - CLI/Codex: dispose registered agent harnesses during short-lived CLI shutdown so successful Codex-backed `agent --local` runs do not leave app-server child processes alive.
diff --git a/ui/src/ui/app-render.assistant-avatar.test.ts b/ui/src/ui/app-render.assistant-avatar.test.ts
@@ -241,6 +241,19 @@ describe("renderApp assistant avatar routing", () => {
     expect(shell?.style.getPropertyValue("--chat-message-max-width")).toBe("min(1280px, 82%)");
   });
 
+  it("passes tools.exec.security to Quick Settings", () => {
+    renderApp(
+      createState({
+        configForm: {
+          tools: { exec: { security: "full" } },
+          agents: { defaults: { exec: { security: "deny" } } },
+        },
+      }),
+    );
+
+    expect(quickSettingsProps.current?.security.execPolicy).toBe("full");
+  });
+
   it("does not throw when stale cron state contains a job without a payload", () => {
     expect(() =>
       renderApp(
diff --git a/ui/src/ui/app-render.ts b/ui/src/ui/app-render.ts
@@ -578,17 +578,14 @@ function extractQuickSettingsSecurity(state: AppViewState): {
       gatewayAuth = "none";
     }
   }
-  const agents = cfg.agents;
   let execPolicy = "allowlist";
-  if (agents && typeof agents === "object") {
-    const defaults = (agents as Record<string, unknown>).defaults;
-    if (defaults && typeof defaults === "object") {
-      const exec = (defaults as Record<string, unknown>).exec;
-      if (exec && typeof exec === "object") {
-        const security = (exec as Record<string, unknown>).security;
-        if (typeof security === "string") {
-          execPolicy = security;
-        }
+  const tools = cfg.tools;
+  if (tools && typeof tools === "object") {
+    const exec = (tools as Record<string, unknown>).exec;
+    if (exec && typeof exec === "object") {
+      const security = (exec as Record<string, unknown>).security;
+      if (typeof security === "string") {
+        execPolicy = security;
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -578,17 +578,14 @@ function extractQuickSettingsSecurity(state: AppViewState): {`
`578`	`578`	`gatewayAuth = "none";`
`579`	`579`	`}`
`580`	`580`	`}`
`581`		`- const agents = cfg.agents;`
`582`	`581`	`let execPolicy = "allowlist";`
`583`		`- if (agents && typeof agents === "object") {`
`584`		`- const defaults = (agents as Record<string, unknown>).defaults;`
`585`		`- if (defaults && typeof defaults === "object") {`
`586`		`- const exec = (defaults as Record<string, unknown>).exec;`
`587`		`- if (exec && typeof exec === "object") {`
`588`		`- const security = (exec as Record<string, unknown>).security;`
`589`		`- if (typeof security === "string") {`
`590`		`- execPolicy = security;`
`591`		`- }`
	`582`	`+ const tools = cfg.tools;`
	`583`	`+ if (tools && typeof tools === "object") {`
	`584`	`+ const exec = (tools as Record<string, unknown>).exec;`
	`585`	`+ if (exec && typeof exec === "object") {`
	`586`	`+ const security = (exec as Record<string, unknown>).security;`
	`587`	`+ if (typeof security === "string") {`
	`588`	`+ execPolicy = security;`
`592`	`589`	`}`
`593`	`590`	`}`
`594`	`591`	`}`