Skip to content

Commit e9e7d38

Browse files
authored
refactor(plugin-runtime): trim task facade exports (#105878)
1 parent 0aabf56 commit e9e7d38

3 files changed

Lines changed: 26 additions & 28 deletions

File tree

scripts/deadcode-exports.baseline.mjs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4787,13 +4787,6 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [
47874787
"src/plugins/runtime/runtime-taskflow.types.ts: BoundTaskFlowTaskRunResult",
47884788
"src/plugins/runtime/runtime-taskflow.types.ts: ManagedTaskFlowCreateParams",
47894789
"src/plugins/runtime/runtime-taskflow.types.ts: ManagedTaskFlowMutationErrorCode",
4790-
"src/plugins/runtime/runtime-tasks.ts: BoundTaskFlowsRuntime",
4791-
"src/plugins/runtime/runtime-tasks.ts: BoundTaskRunsRuntime",
4792-
"src/plugins/runtime/runtime-tasks.ts: createRuntimeTaskFlows",
4793-
"src/plugins/runtime/runtime-tasks.ts: createRuntimeTaskRuns",
4794-
"src/plugins/runtime/runtime-tasks.ts: PluginRuntimeTaskFlows",
4795-
"src/plugins/runtime/runtime-tasks.ts: PluginRuntimeTaskRuns",
4796-
"src/plugins/runtime/runtime-tasks.ts: PluginRuntimeTasks",
47974790
"src/plugins/runtime/runtime-tasks.types.ts: TaskFlowView",
47984791
"src/plugins/runtime/runtime-tasks.types.ts: TaskRunAggregateSummary",
47994792
"src/plugins/runtime/runtime-tasks.types.ts: TaskRunDetail",

src/plugins/runtime/runtime-tasks.test.ts

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
resetRuntimeTaskTestState,
1111
} from "./runtime-task-test-harness.js";
1212
import { createRuntimeTaskFlow } from "./runtime-taskflow.js";
13-
import { createRuntimeTaskFlows, createRuntimeTaskRuns } from "./runtime-tasks.js";
13+
import { createRuntimeTasks } from "./runtime-tasks.js";
1414

1515
const runtimeTaskMocks = getRuntimeTaskMocks();
1616

@@ -48,23 +48,26 @@ describe("runtime tasks", () => {
4848
});
4949

5050
it("exposes canonical task and TaskFlow DTOs without leaking raw registry fields", () => {
51-
const legacyTaskFlow = createRuntimeTaskFlow().bindSession({
51+
const runtimeTasks = createRuntimeTasks({
52+
legacyTaskFlow: createRuntimeTaskFlow(),
53+
});
54+
const legacyTaskFlow = runtimeTasks.managedFlows.bindSession({
5255
sessionKey: "agent:main:main",
5356
requesterOrigin: {
5457
channel: "telegram",
5558
to: "telegram:123",
5659
},
5760
});
58-
const taskFlows = createRuntimeTaskFlows().bindSession({
61+
const taskFlows = runtimeTasks.flows.bindSession({
5962
sessionKey: "agent:main:main",
6063
});
61-
const taskRuns = createRuntimeTaskRuns().bindSession({
64+
const taskRuns = runtimeTasks.runs.bindSession({
6265
sessionKey: "agent:main:main",
6366
});
64-
const otherTaskFlows = createRuntimeTaskFlows().bindSession({
67+
const otherTaskFlows = runtimeTasks.flows.bindSession({
6568
sessionKey: "agent:main:other",
6669
});
67-
const otherTaskRuns = createRuntimeTaskRuns().bindSession({
70+
const otherTaskRuns = runtimeTasks.runs.bindSession({
6871
sessionKey: "agent:main:other",
6972
});
7073

@@ -145,10 +148,13 @@ describe("runtime tasks", () => {
145148
});
146149

147150
it("maps task cancellation results onto canonical task DTOs", async () => {
148-
const legacyTaskFlow = createRuntimeTaskFlow().bindSession({
151+
const runtimeTasks = createRuntimeTasks({
152+
legacyTaskFlow: createRuntimeTaskFlow(),
153+
});
154+
const legacyTaskFlow = runtimeTasks.managedFlows.bindSession({
149155
sessionKey: "agent:main:main",
150156
});
151-
const taskRuns = createRuntimeTaskRuns().bindSession({
157+
const taskRuns = runtimeTasks.runs.bindSession({
152158
sessionKey: "agent:main:main",
153159
});
154160

@@ -191,10 +197,13 @@ describe("runtime tasks", () => {
191197
});
192198

193199
it("routes runtime task cancellation through the detached task runtime seam", async () => {
194-
const legacyTaskFlow = createRuntimeTaskFlow().bindSession({
200+
const runtimeTasks = createRuntimeTasks({
201+
legacyTaskFlow: createRuntimeTaskFlow(),
202+
});
203+
const legacyTaskFlow = runtimeTasks.managedFlows.bindSession({
195204
sessionKey: "agent:main:main",
196205
});
197-
const taskRuns = createRuntimeTaskRuns().bindSession({
206+
const taskRuns = runtimeTasks.runs.bindSession({
198207
sessionKey: "agent:main:main",
199208
});
200209

@@ -240,10 +249,13 @@ describe("runtime tasks", () => {
240249
});
241250

242251
it("does not allow cross-owner task cancellation or leak task details", async () => {
243-
const legacyTaskFlow = createRuntimeTaskFlow().bindSession({
252+
const runtimeTasks = createRuntimeTasks({
253+
legacyTaskFlow: createRuntimeTaskFlow(),
254+
});
255+
const legacyTaskFlow = runtimeTasks.managedFlows.bindSession({
244256
sessionKey: "agent:main:main",
245257
});
246-
const otherTaskRuns = createRuntimeTaskRuns().bindSession({
258+
const otherTaskRuns = runtimeTasks.runs.bindSession({
247259
sessionKey: "agent:main:other",
248260
});
249261

src/plugins/runtime/runtime-tasks.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,6 @@ import type {
3131
TaskFlowDetail,
3232
TaskRunCancelResult,
3333
} from "./runtime-tasks.types.js";
34-
export type {
35-
BoundTaskFlowsRuntime,
36-
BoundTaskRunsRuntime,
37-
PluginRuntimeTaskFlows,
38-
PluginRuntimeTaskRuns,
39-
PluginRuntimeTasks,
40-
} from "./runtime-tasks.types.js";
4134

4235
function assertSessionKey(sessionKey: string | undefined, errorMessage: string): string {
4336
const normalized = sessionKey?.trim();
@@ -176,7 +169,7 @@ function createBoundTaskFlowsRuntime(params: {
176169
};
177170
}
178171

179-
export function createRuntimeTaskRuns(): PluginRuntimeTaskRuns {
172+
function createRuntimeTaskRuns(): PluginRuntimeTaskRuns {
180173
return {
181174
bindSession: (params) =>
182175
createBoundTaskRunsRuntime({
@@ -194,7 +187,7 @@ export function createRuntimeTaskRuns(): PluginRuntimeTaskRuns {
194187
};
195188
}
196189

197-
export function createRuntimeTaskFlows(): PluginRuntimeTaskFlows {
190+
function createRuntimeTaskFlows(): PluginRuntimeTaskFlows {
198191
return {
199192
bindSession: (params) =>
200193
createBoundTaskFlowsRuntime({

0 commit comments

Comments
 (0)