Skip to content

Commit e91c37f

Browse files
authored
Merge branch 'main' into fix/subagent-model-resolution
2 parents 2920866 + 86b10ff commit e91c37f

2,140 files changed

Lines changed: 176256 additions & 55531 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.agents/skills/autoreview/SKILL.md

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,17 @@ Set the skill script paths once, then use `"$AUTOREVIEW"` and `"$AUTOREVIEW_HARN
9191
Choose one:
9292

9393
```bash
94-
# Project-local skill in the current repo:
94+
# Project-local skill in the current repo for Codex and other agents:
9595
export AUTOREVIEW=".agents/skills/autoreview/scripts/autoreview"
9696
export AUTOREVIEW_HARNESS=".agents/skills/autoreview/scripts/test-review-harness"
9797
```
9898

99+
```bash
100+
# Claude Code project-local skill in the current repo:
101+
export AUTOREVIEW=".claude/skills/autoreview/scripts/autoreview"
102+
export AUTOREVIEW_HARNESS=".claude/skills/autoreview/scripts/test-review-harness"
103+
```
104+
99105
```bash
100106
# Source checkout of openclaw/agent-skills:
101107
export AUTOREVIEW="skills/autoreview/scripts/autoreview"
@@ -109,16 +115,22 @@ export AUTOREVIEW="$AGENTS_HOME/skills/autoreview/scripts/autoreview"
109115
export AUTOREVIEW_HARNESS="$AGENTS_HOME/skills/autoreview/scripts/test-review-harness"
110116
```
111117

112-
When using Claude Code, set `AGENTS_HOME="$HOME/.claude"` for global skills. Project-local skills live under `.claude/skills/` in the current repo.
118+
When using Claude Code, set `AGENTS_HOME="$HOME/.claude"` for global skills.
113119

114120
On native Windows, choose the matching pair:
115121

116122
```powershell
117-
# Project-local skill in the current repo:
123+
# Project-local skill in the current repo for Codex and other agents:
118124
$AUTOREVIEW = ".agents\skills\autoreview\scripts\autoreview"
119125
$AUTOREVIEW_HARNESS = ".agents\skills\autoreview\scripts\test-review-harness.ps1"
120126
```
121127

128+
```powershell
129+
# Claude Code project-local skill in the current repo:
130+
$AUTOREVIEW = ".claude\skills\autoreview\scripts\autoreview"
131+
$AUTOREVIEW_HARNESS = ".claude\skills\autoreview\scripts\test-review-harness.ps1"
132+
```
133+
122134
```powershell
123135
# Source checkout of openclaw/agent-skills:
124136
$AUTOREVIEW = "skills\autoreview\scripts\autoreview"
@@ -188,6 +200,12 @@ Format first if formatting can change line locations. Then it is OK to run tests
188200
On Windows, the default `--parallel-tests` shell preserves the platform `cmd.exe`
189201
semantics used by Python `shell=True`. Use `--parallel-tests-shell powershell`
190202
or `--parallel-tests-shell pwsh` when the focused test command is PowerShell-specific.
203+
Parallel tests inherit only a small allowlist of ordinary OS, CI, and toolchain
204+
variables. Put additional non-secret project controls directly in the test command.
205+
Home and standard config directories point to a temporary isolated root that is
206+
removed after the command exits. Do not put secrets in the command because it is
207+
printed before execution. Run secret-bearing or credentialed tests separately in an
208+
appropriately isolated remote runner.
191209

192210
Tradeoff: tests may force code changes that stale the review. If tests or review lead to code edits, rerun the affected tests and rerun review until no accepted/actionable findings remain. Once that rerun exits cleanly, stop; do not spend another long review cycle on redundant confirmation.
193211

@@ -295,6 +313,7 @@ loader such as an untracked `.envrc`; the helper does not write a config file.
295313
| `AUTOREVIEW_CODEX_CONFIG` | Safe Codex model/response tuning overrides, semicolon-separated, e.g. `service_tier="fast"`; capability-bearing keys fail closed |
296314
| `AUTOREVIEW_CODEX_SPEED` | Codex service tier override: `fast` (priority), `flex`, or `default`; silently standard when the model does not list the tier |
297315
| `AUTOREVIEW_CLAUDE_FALLBACK_MODEL` | Claude-only fallback chain |
316+
| `AUTOREVIEW_PROVIDER_ENV_ALLOW` | Comma-separated custom Pi/OpenCode credential variable names; names must end in a recognized credential suffix |
298317

299318
Codex maps thinking to `model_reasoning_effort`. Claude maps thinking to `--effort`. Pi maps thinking to `--thinking`. Only Claude accepts `--fallback-model`; global CLI/env fallback requires at least one Claude reviewer, and engine-specific fallback overrides require that reviewer to be selected. Non-Claude fallback overrides, including `AUTOREVIEW_<NONCLAUDE>_FALLBACK_MODEL`, fail closed instead of being silently ignored.
300319

0 commit comments

Comments
 (0)