fix: narrow exit 130 to doctor-prompter path only

SebTardif · SebTardif · commit e7e4539f148e · 2026-07-01T11:56:44.000-07:00
Revert guardCancel to exit 0 by default (matching main) and pass
exit code 130 only from doctor-prompter where the installer needs
to distinguish user cancellation from normal failures.

This preserves the existing cancellation behavior for configure,
wizard, gateway, and daemon prompts while keeping the SIGINT
convention for the installer's doctor subprocess.

Signed-off-by: Sebastien Tardif &lt;sebtardif@ncf.ca&gt;
diff --git a/src/commands/doctor-prompter.ts b/src/commands/doctor-prompter.ts
@@ -47,12 +47,15 @@ export function createDoctorPrompter(params: {
     if (!repairMode.canPrompt) {
       return p.initialValue ?? false;
     }
+    // Exit 130 (SIGINT convention) so the installer can distinguish
+    // user cancellation from normal doctor failures.
     return guardCancel(
       await confirm({
         ...p,
         message: stylePromptMessage(p.message),
       }),
       params.runtime,
+      130,
     );
   };
 
@@ -78,6 +81,7 @@ export function createDoctorPrompter(params: {
           message: stylePromptMessage(p.message),
         }),
         params.runtime,
+        130,
       );
     },
     confirmRuntimeRepair: async (p) => {
@@ -103,6 +107,7 @@ export function createDoctorPrompter(params: {
           message: stylePromptMessage(confirmParams.message),
         }),
         params.runtime,
+        130,
       );
     },
     select: async <T>(p: Parameters<typeof select>[0], fallback: T) => {
@@ -118,6 +123,7 @@ export function createDoctorPrompter(params: {
           ),
         }),
         params.runtime,
+        130,
       ) as T;
     },
     shouldRepair: repairMode.shouldRepair,
diff --git a/src/commands/onboard-helpers.ts b/src/commands/onboard-helpers.ts
@@ -47,11 +47,11 @@ export { detectBinary };
 export { detectBrowserOpenSupport, openUrl, resolveBrowserOpenCommand };
 export { resolveAdvertisedControlUiLinks, resolveControlUiLinks, resolveLocalControlUiProbeLinks };
 
-/** Handles Clack cancellation by exiting with SIGINT convention (130). */
-export function guardCancel<T>(value: T | symbol, runtime: RuntimeEnv): T {
+/** Handles Clack cancellation by exiting through the runtime. */
+export function guardCancel<T>(value: T | symbol, runtime: RuntimeEnv, exitCode = 0): T {
   if (isCancel(value)) {
     cancel(stylePromptTitle("Setup cancelled.") ?? "Setup cancelled.");
-    runtime.exit(130);
+    runtime.exit(exitCode);
     throw new Error("unreachable");
   }
   return value;
