fix(line): address review feedback on media auth handling

Takhoffman · Takhoffman · commit e65bc320c4f4 · 2026-03-02T22:53:44.000-06:00
diff --git a/src/line/bot-handlers.test.ts b/src/line/bot-handlers.test.ts
@@ -288,6 +288,7 @@ describe("handleLineWebhookEvents", () => {
     expect(buildLineMessageContextMock).toHaveBeenCalledTimes(1);
     expect(buildLineMessageContextMock).toHaveBeenCalledWith(
       expect.objectContaining({
+        commandAuthorized: true,
         allMedia: [
           {
             path: "/tmp/line-media-file.pdf",
diff --git a/src/line/bot-handlers.ts b/src/line/bot-handlers.ts
@@ -226,7 +226,10 @@ async function shouldProcessLineEvent(
       allowTextCommands: true,
       hasControlCommand: hasControlCommand(rawText, cfg),
     });
-    return { allowed: true, commandAuthorized: commandGate.commandAuthorized };
+    return {
+      allowed: true,
+      commandAuthorized: isNonTextLineMessageEvent(event) ? true : commandGate.commandAuthorized,
+    };
   }
 
   if (dmPolicy === "disabled") {
@@ -263,7 +266,10 @@ async function shouldProcessLineEvent(
     allowTextCommands: true,
     hasControlCommand: hasControlCommand(rawText, cfg),
   });
-  return { allowed: true, commandAuthorized: commandGate.commandAuthorized };
+  return {
+    allowed: true,
+    commandAuthorized: isNonTextLineMessageEvent(event) ? true : commandGate.commandAuthorized,
+  };
 }
 
 /** Extract raw text from a LINE message or postback event for command detection. */
@@ -281,6 +287,12 @@ function resolveEventRawText(event: MessageEvent | PostbackEvent): string {
   return "";
 }
 
+function isNonTextLineMessageEvent(
+  event: MessageEvent | PostbackEvent,
+): event is MessageEvent & { message: Exclude<MessageEvent["message"], { type: "text" }> } {
+  return event.type === "message" && event.message.type !== "text";
+}
+
 async function handleMessageEvent(event: MessageEvent, context: LineHandlerContext): Promise<void> {
   const { cfg, account, runtime, mediaMaxBytes, processMessage } = context;
   const message = event.message;
diff --git a/src/line/download.ts b/src/line/download.ts
@@ -9,6 +9,8 @@ interface DownloadResult {
   size: number;
 }
 
+const AUDIO_BRANDS = new Set(["m4a ", "m4b ", "m4p ", "m4r ", "f4a ", "f4b "]);
+
 export async function downloadLineMedia(
   messageId: string,
   channelAccessToken: string,
@@ -91,8 +93,7 @@ function detectContentType(buffer: Buffer): string {
       // ISO BMFF containers share `ftyp`; use major brand to separate common
       // M4A audio payloads from video mp4 containers.
       const majorBrand = buffer.toString("ascii", 8, 12).toLowerCase();
-      const audioBrands = new Set(["m4a ", "m4b ", "m4p ", "m4r ", "f4a ", "f4b "]);
-      if (audioBrands.has(majorBrand)) {
+      if (AUDIO_BRANDS.has(majorBrand)) {
         return "audio/mp4";
       }
       return "video/mp4";

Original file line number	Diff line number	Diff line change
`@@ -288,6 +288,7 @@ describe("handleLineWebhookEvents", () => {`
`288`	`288`	`expect(buildLineMessageContextMock).toHaveBeenCalledTimes(1);`
`289`	`289`	`expect(buildLineMessageContextMock).toHaveBeenCalledWith(`
`290`	`290`	`expect.objectContaining({`
	`291`	`+ commandAuthorized: true,`
`291`	`292`	`allMedia: [`
`292`	`293`	`{`
`293`	`294`	`path: "/tmp/line-media-file.pdf",`