fix(discord): exclude '*' wildcard from unresolvedChannels count

SidQin-cyber · SidQin-cyber · commit e39291d0a8e3 · 2026-03-03T17:01:06.000+08:00
The channel audit counted the '*' wildcard key as an unresolved channel, producing a false positive warning in doctor/channels-status even though '*' is a valid config meaning "allow all channels in this guild". Closes #32517 Made-with: Cursor
diff --git a/src/discord/audit.test.ts b/src/discord/audit.test.ts
@@ -36,6 +36,31 @@ describe("discord audit", () => {
     expect(collected.channelIds).toEqual(["111"]);
     expect(collected.unresolvedChannels).toBe(1);
 
+    const cfgWildcard = {
+      channels: {
+        discord: {
+          enabled: true,
+          token: "t",
+          groupPolicy: "allowlist",
+          guilds: {
+            "123": {
+              channels: {
+                "*": { allow: true },
+                "111": { allow: true },
+              },
+            },
+          },
+        },
+      },
+    } as unknown as import("../config/config.js").OpenClawConfig;
+
+    const wildcardResult = collectDiscordAuditChannelIds({
+      cfg: cfgWildcard,
+      accountId: "default",
+    });
+    expect(wildcardResult.channelIds).toEqual(["111"]);
+    expect(wildcardResult.unresolvedChannels).toBe(0);
+
     (fetchChannelPermissionsDiscord as unknown as ReturnType<typeof vi.fn>).mockResolvedValueOnce({
       channelId: "111",
       permissions: ["ViewChannel"],
@@ -53,4 +78,29 @@ describe("discord audit", () => {
     expect(audit.channels[0]?.channelId).toBe("111");
     expect(audit.channels[0]?.missing).toContain("SendMessages");
   });
+
+  it("does not count '*' wildcard as unresolved (#32517)", async () => {
+    const { collectDiscordAuditChannelIds } = await import("./audit.js");
+
+    const cfg = {
+      channels: {
+        discord: {
+          enabled: true,
+          token: "t",
+          groupPolicy: "allowlist",
+          guilds: {
+            "999": {
+              channels: {
+                "*": { allow: true },
+              },
+            },
+          },
+        },
+      },
+    } as unknown as import("../config/config.js").OpenClawConfig;
+
+    const result = collectDiscordAuditChannelIds({ cfg, accountId: "default" });
+    expect(result.channelIds).toEqual([]);
+    expect(result.unresolvedChannels).toBe(0);
+  });
 });
diff --git a/src/discord/audit.ts b/src/discord/audit.ts
@@ -75,7 +75,8 @@ export function collectDiscordAuditChannelIds(params: {
   });
   const keys = listConfiguredGuildChannelKeys(account.config.guilds);
   const channelIds = keys.filter((key) => /^\d+$/.test(key));
-  const unresolvedChannels = keys.length - channelIds.length;
+  const wildcardCount = keys.filter((key) => key === "*").length;
+  const unresolvedChannels = Math.max(0, keys.length - channelIds.length - wildcardCount);
   return { channelIds, unresolvedChannels };
 }
 

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,8 @@ export function collectDiscordAuditChannelIds(params: {`
`75`	`75`	`});`
`76`	`76`	`const keys = listConfiguredGuildChannelKeys(account.config.guilds);`
`77`	`77`	`const channelIds = keys.filter((key) => /^\d+$/.test(key));`
`78`		`- const unresolvedChannels = keys.length - channelIds.length;`
	`78`	`+ const wildcardCount = keys.filter((key) => key === "*").length;`
	`79`	`+ const unresolvedChannels = Math.max(0, keys.length - channelIds.length - wildcardCount);`
`79`	`80`	`return { channelIds, unresolvedChannels };`
`80`	`81`	`}`
`81`	`82`