fix(voice-call): preserve live Twilio streams in stale reaper

sahibzada-allahyar · sahibzada-allahyar · commit e1cd850a9afa · 2026-06-05T11:00:15.000+01:00
diff --git a/extensions/voice-call/src/webhook.test.ts b/extensions/voice-call/src/webhook.test.ts
@@ -616,6 +616,21 @@ describe("VoiceCallWebhookServer stale call reaper", () => {
     });
     expect(endCall).not.toHaveBeenCalled();
   });
+
+  it("does not reap live calls in speaking state without answeredAt (inbound Twilio)", async () => {
+    const { endCall } = await runStaleCallReaperCase({
+      callAgeMs: 120_000,
+      staleCallReaperSeconds: 60,
+      advanceMs: 30_000,
+      callOverrides: {
+        state: "speaking",
+        // answeredAt intentionally absent — inbound Twilio calls never fire
+        // call.answered, so answeredAt stays undefined even while live.
+        answeredAt: undefined,
+      },
+    });
+    expect(endCall).not.toHaveBeenCalled();
+  });
 });
 
 describe("VoiceCallWebhookServer path matching", () => {
diff --git a/extensions/voice-call/src/webhook/stale-call-reaper.ts b/extensions/voice-call/src/webhook/stale-call-reaper.ts
@@ -1,11 +1,18 @@
 // Voice Call plugin module implements stale call reaper behavior.
 import type { CallManager } from "../manager.js";
+import type { CallState } from "../types.js";
 import { TerminalStates } from "../types.js";
 
 // Background cleanup loop for calls that never reached answered/terminal state.
 
 const CHECK_INTERVAL_MS = 30_000;
 
+/** States that indicate a live conversation with speech/transcription.
+ * Inbound Twilio calls may never fire a call.answered event, so answeredAt
+ * can be absent even while the call is actively transcribing. These states
+ * prove the call is live and should not be reaped. */
+const LiveConversationStates: ReadonlySet<CallState> = new Set(["speaking", "listening"]);
+
 /** Start a stale-call reaper and return its cleanup callback. */
 export function startStaleCallReaper(params: {
   manager: CallManager;
@@ -20,7 +27,16 @@ export function startStaleCallReaper(params: {
   const interval = setInterval(() => {
     const now = Date.now();
     for (const call of params.manager.getActiveCalls()) {
-      if (call.answeredAt || TerminalStates.has(call.state)) {
+      // Skip calls that have been answered (answeredAt set) or are in a live
+      // conversation state. Inbound Twilio calls may never fire a call.answered
+      // event so answeredAt may be absent even when the call is actively
+      // transcribing/responding. Without this state guard live calls in
+      // speaking/listening state get reaped as stale.
+      if (
+        call.answeredAt ||
+        TerminalStates.has(call.state) ||
+        LiveConversationStates.has(call.state)
+      ) {
         continue;
       }
 
