fix(cli): allow zero Discord timeout duration

rohitjavvadi · rohitjavvadi · commit e18ca11dfb3a · 2026-06-15T20:34:23.000+05:30
diff --git a/src/cli/program/message/helpers.test.ts b/src/cli/program/message/helpers.test.ts
@@ -60,6 +60,8 @@ vi.mock("../../deps.js", () => ({
 
 const { createMessageCliHelpers } = await import("./helpers.js");
 
+const NON_NEGATIVE_INTEGER_FLAGS = new Set(["--delete-days", "--duration-min"]);
+
 const baseSendOptions = {
   channel: "discord",
   target: "123",
@@ -365,7 +367,7 @@ describe("runMessageAction", () => {
 
     await expect(runMessageAction(action, opts)).rejects.toThrow("exit");
 
-    const kind = flag === "--delete-days" ? "non-negative" : "positive";
+    const kind = NON_NEGATIVE_INTEGER_FLAGS.has(flag) ? "non-negative" : "positive";
     expect(errorMock).toHaveBeenCalledWith(`Error: ${flag} must be a ${kind} integer.`);
     expect(ensurePluginRegistryLoaded).not.toHaveBeenCalled();
     expect(messageCommandMock).not.toHaveBeenCalled();
@@ -390,7 +392,7 @@ describe("runMessageAction", () => {
       }),
     ).rejects.toThrow("exit");
 
-    const kind = flag === "--delete-days" ? "non-negative" : "positive";
+    const kind = NON_NEGATIVE_INTEGER_FLAGS.has(flag) ? "non-negative" : "positive";
     expect(errorMock).toHaveBeenCalledWith(`Error: ${flag} must be a ${kind} integer.`);
     expect(messageCommandMock).not.toHaveBeenCalled();
     expect(exitMock).toHaveBeenCalledWith(1);
@@ -417,6 +419,27 @@ describe("runMessageAction", () => {
     expect(exitMock).toHaveBeenCalledWith(0);
   });
 
+  it("allows zero duration-min for clearing Discord timeouts", async () => {
+    const runMessageAction = createRunMessageAction();
+
+    await expect(
+      runMessageAction("timeout", {
+        guildId: "g",
+        userId: "u",
+        durationMin: "0",
+      }),
+    ).rejects.toThrow("exit");
+
+    expect(errorMock).not.toHaveBeenCalled();
+    expectMessageCommandOptions({
+      action: "timeout",
+      guildId: "g",
+      userId: "u",
+      durationMin: "0",
+    });
+    expect(exitMock).toHaveBeenCalledWith(0);
+  });
+
   it("runs gateway_stop hooks before exit when registered", async () => {
     hasHooksMock.mockReturnValueOnce(true);
     await runSendAction();
diff --git a/src/cli/program/message/helpers.ts b/src/cli/program/message/helpers.ts
@@ -34,11 +34,13 @@ const CHANNEL_MESSAGE_ACTION_NAME_SET = new Set<string>(CHANNEL_MESSAGE_ACTION_N
 const STRICT_POSITIVE_INTEGER_OPTIONS = new Map([
   ["pollDurationHours", "--poll-duration-hours"],
   ["pollDurationSeconds", "--poll-duration-seconds"],
-  ["durationMin", "--duration-min"],
   ["limit", "--limit"],
   ["autoArchiveMin", "--auto-archive-min"],
 ]);
-const STRICT_NON_NEGATIVE_INTEGER_OPTIONS = new Map([["deleteDays", "--delete-days"]]);
+const STRICT_NON_NEGATIVE_INTEGER_OPTIONS = new Map([
+  ["durationMin", "--duration-min"],
+  ["deleteDays", "--delete-days"],
+]);
 
 type MessagePluginLoadOptions = { scope: PluginRegistryScope; onlyChannelIds?: string[] };
 type MessagePluginPreloadPlan =
