test(huggingface): avoid unbound reader assertions

steipete · steipete · commit dda99df92220 · 2026-07-06T18:07:40.000-04:00
diff --git a/extensions/huggingface/models.test.ts b/extensions/huggingface/models.test.ts
@@ -121,43 +121,52 @@ describe("huggingface models", () => {
     process.env.VITEST = "false";
     process.env.NODE_ENV = "development";
     const chunk = new Uint8Array(1024 * 1024);
+    const read = vi.fn(async () => ({ done: false as const, value: chunk }));
     const cancel = vi.fn(async () => undefined);
     const releaseLock = vi.fn();
     const reader = {
-      read: vi.fn(async () => ({ done: false as const, value: chunk })),
+      read,
       cancel,
       releaseLock,
     } as unknown as ReadableStreamDefaultReader<Uint8Array>;
-    vi.stubGlobal("fetch", vi.fn(async () => responseFromReader(reader)));
+    vi.stubGlobal(
+      "fetch",
+      vi.fn(async () => responseFromReader(reader)),
+    );
 
     const models = await discoverHuggingfaceModels("hf_test_token");
 
     expect(models.map((m) => m.id)).toEqual(HUGGINGFACE_MODEL_CATALOG.map((m) => m.id));
     expect(cancel).toHaveBeenCalledTimes(1);
     expect(releaseLock).toHaveBeenCalledTimes(1);
-    expect(reader.read).toHaveBeenCalledTimes(17);
+    expect(read).toHaveBeenCalledTimes(17);
   });
 
   it("parses a valid bounded discovery response", async () => {
     process.env.VITEST = "false";
     process.env.NODE_ENV = "development";
     const modelId = "test-org/test-model";
     const body = new TextEncoder().encode(JSON.stringify({ data: [{ id: modelId }] }));
+    const read = vi
+      .fn()
+      .mockResolvedValueOnce({ done: false, value: body })
+      .mockResolvedValueOnce({ done: true, value: undefined });
+    const cancel = vi.fn(async () => undefined);
     const releaseLock = vi.fn();
     const reader = {
-      read: vi
-        .fn()
-        .mockResolvedValueOnce({ done: false, value: body })
-        .mockResolvedValueOnce({ done: true, value: undefined }),
-      cancel: vi.fn(async () => undefined),
+      read,
+      cancel,
       releaseLock,
     } as unknown as ReadableStreamDefaultReader<Uint8Array>;
-    vi.stubGlobal("fetch", vi.fn(async () => responseFromReader(reader)));
+    vi.stubGlobal(
+      "fetch",
+      vi.fn(async () => responseFromReader(reader)),
+    );
 
     const models = await discoverHuggingfaceModels("hf_test_token");
 
     expect(models.some((model) => model.id === modelId)).toBe(true);
-    expect(reader.cancel).not.toHaveBeenCalled();
+    expect(cancel).not.toHaveBeenCalled();
     expect(releaseLock).toHaveBeenCalledTimes(1);
   });
 
