fix(update): handle default enabled Windows tasks

vincentkoc · vincentkoc · commit da348c17f407 · 2026-05-31T13:36:04.000+02:00
diff --git a/src/daemon/schtasks.stop.test.ts b/src/daemon/schtasks.stop.test.ts
@@ -119,7 +119,7 @@ describe("Scheduled Task stop/restart cleanup", () => {
         { ...SUCCESS_RESPONSE },
         {
           ...SUCCESS_RESPONSE,
-          stdout: "<Task><Settings><Enabled>true</Enabled></Settings></Task>",
+          stdout: "<Task><Settings><StartWhenAvailable>true</StartWhenAvailable></Settings></Task>",
         },
         { ...SUCCESS_RESPONSE },
       );
@@ -201,6 +201,28 @@ describe("Scheduled Task stop/restart cleanup", () => {
     });
   });
 
+  it("treats omitted Settings Enabled state as enabled", async () => {
+    await withPreparedGatewayTask(async ({ env }) => {
+      schtasksResponses.push(
+        { ...SUCCESS_RESPONSE },
+        {
+          ...SUCCESS_RESPONSE,
+          stdout:
+            "<Task><Triggers><LogonTrigger><Enabled>false</Enabled></LogonTrigger></Triggers><Settings><Hidden>false</Hidden></Settings></Task>",
+        },
+        { ...SUCCESS_RESPONSE },
+      );
+
+      await expect(suspendScheduledTaskAutoStartForUpdate(env)).resolves.toBe(true);
+
+      expect(schtasksCalls).toEqual([
+        ["/Query"],
+        ["/Query", "/TN", "OpenClaw Gateway", "/XML"],
+        ["/Change", "/TN", "OpenClaw Gateway", "/DISABLE"],
+      ]);
+    });
+  });
+
   it("reads NUL-separated Scheduled Task XML enabled state", async () => {
     await withPreparedGatewayTask(async ({ env }) => {
       const xml = "<Task><Settings><Enabled>true</Enabled></Settings></Task>";
diff --git a/src/daemon/schtasks.ts b/src/daemon/schtasks.ts
@@ -1283,10 +1283,13 @@ function isTaskNotRunning(res: { stdout: string; stderr: string; code: number })
 function parseScheduledTaskXmlEnabled(output: string): boolean | null {
   const normalizedOutput = output.replace(/^\uFEFF/u, "").replaceAll(String.fromCharCode(0), "");
   const settings = /<Settings(?:\s[^>]*)?>([\s\S]*?)<\/Settings>/iu.exec(normalizedOutput);
-  const match = settings?.[1] ? /<Enabled>\s*(true|false)\s*<\/Enabled>/iu.exec(settings[1]) : null;
-  if (!match?.[1]) {
+  if (!settings?.[1]) {
     return null;
   }
+  const match = /<Enabled>\s*(true|false)\s*<\/Enabled>/iu.exec(settings[1]);
+  if (!match?.[1]) {
+    return true;
+  }
   return match[1].toLowerCase() === "true";
 }
 
