Skip to content

Commit da15cf4

Browse files
committed
fix(maint): keep PR landing on squash
1 parent 54c0048 commit da15cf4

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

scripts/pr-lib/merge.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ merge_run() {
225225
}
226226

227227
if ! gh pr merge "$pr" \
228-
--rebase \
228+
--squash \
229229
--match-head-commit "$PREP_HEAD_SHA" \
230230
>.local/merge-output.log 2>&1
231231
then
@@ -290,7 +290,7 @@ merge_run() {
290290
for attempt in 1 2 3; do
291291
if comment_output=$(
292292
{
293-
echo "Merged via rebase."
293+
echo "Merged via squash."
294294
echo
295295
echo "- Prepared head SHA: [$PREP_HEAD_SHA]($prep_sha_url)"
296296
echo "- Landed commit: [$landed_sha]($landed_sha_url)"

test/scripts/pr-wrappers.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@ describe("scripts/pr wrappers", () => {
3232
expect(script).toContain('exec "$base" merge-run "$pr"');
3333
});
3434

35-
it("uses the repository-approved rebase landing method", () => {
35+
it("uses the repository-approved squash landing method", () => {
3636
const script = readScript("scripts/pr-lib/merge.sh");
3737

38-
expect(script).toContain("--rebase");
39-
expect(script).not.toContain("--squash");
40-
expect(script).toContain("Merged via rebase.");
41-
expect(script).not.toContain("Merged via squash.");
38+
expect(script).toContain("--squash");
39+
expect(script).not.toContain("--rebase");
40+
expect(script).toContain("Merged via squash.");
41+
expect(script).not.toContain("Merged via rebase.");
4242
});
4343

4444
it("keeps prepare wrapper modes delegated to the main PR helper", () => {

0 commit comments

Comments
 (0)