fix(zalo): accept hex-like chat_id values in targetResolver

xzh-icenter · xzh-icenter · commit d84ef0a4fdd1 · 2026-06-06T13:45:39.000+08:00
The Zalo Bot API accepts both numeric and hex-like chat_id values. However, targetResolver.looksLikeId was using isNumericTargetId, which only accepted 3+ digit strings. This caused the CLI to reject valid hex chat IDs with 'Unknown target'. - Replace isNumericTargetId with isZaloTargetId in the Zalo plugin - isZaloTargetId accepts numeric (3+ digits) and hex-like (16+ chars) - Add unit tests for the new validation Fixes #57594
diff --git a/extensions/zalo/src/channel.target.test.ts b/extensions/zalo/src/channel.target.test.ts
@@ -0,0 +1,38 @@
+import { describe, expect, it } from "vitest";
+import { zaloPlugin } from "./channel.js";
+
+describe("zalo targetResolver", () => {
+  const looksLikeId = zaloPlugin.messaging?.targetResolver?.looksLikeId;
+
+  it("accepts numeric chat_id (3+ digits)", () => {
+    expect(looksLikeId?.("123456")).toBe(true);
+    expect(looksLikeId?.("1234567890")).toBe(true);
+  });
+
+  it("accepts hex-like chat_id (16+ hex chars)", () => {
+    expect(looksLikeId?.("5a0b1c2d3e4f5a6b")).toBe(true);
+    expect(looksLikeId?.("5A0B1C2D3E4F5A6B")).toBe(true);
+    expect(looksLikeId?.("a1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6")).toBe(true);
+  });
+
+  it("rejects too short numeric strings", () => {
+    expect(looksLikeId?.("12")).toBe(false);
+    expect(looksLikeId?.("1")).toBe(false);
+  });
+
+  it("rejects too short hex strings", () => {
+    expect(looksLikeId?.("abc123")).toBe(false);
+    expect(looksLikeId?.("a1b2c3d4")).toBe(false);
+  });
+
+  it("rejects invalid characters", () => {
+    expect(looksLikeId?.("hello")).toBe(false);
+    expect(looksLikeId?.("zalo:123")).toBe(false);
+    expect(looksLikeId?.("")).toBe(false);
+  });
+
+  it("trims whitespace before checking", () => {
+    expect(looksLikeId?.("  123456  ")).toBe(true);
+    expect(looksLikeId?.("  5a0b1c2d3e4f5a6b  ")).toBe(true);
+  });
+});
diff --git a/extensions/zalo/src/channel.ts b/extensions/zalo/src/channel.ts
@@ -30,10 +30,7 @@ import { createStaticReplyToModeResolver } from "openclaw/plugin-sdk/conversatio
 import { createChannelDirectoryAdapter } from "openclaw/plugin-sdk/directory-runtime";
 import { listResolvedDirectoryUserEntriesFromAllowFrom } from "openclaw/plugin-sdk/directory-runtime";
 import { createLazyRuntimeModule } from "openclaw/plugin-sdk/lazy-runtime";
-import {
-  isNumericTargetId,
-  sendPayloadWithChunkedTextAndMedia,
-} from "openclaw/plugin-sdk/reply-payload";
+import { sendPayloadWithChunkedTextAndMedia } from "openclaw/plugin-sdk/reply-payload";
 import {
   createComputedAccountStatusAdapter,
   createDefaultChannelRuntimeState,
@@ -74,6 +71,23 @@ function normalizeZaloMessagingTarget(raw: string): string | undefined {
   return trimmed.replace(/^(zalo|zl):/i, "").trim();
 }
 
+/** Detect Zalo Bot API chat_id values, which may be numeric or hex-like. */
+function isZaloTargetId(raw: string): boolean {
+  const trimmed = raw?.trim();
+  if (!trimmed) {
+    return false;
+  }
+  // Numeric chat_id (original check)
+  if (/^\d{3,}$/.test(trimmed)) {
+    return true;
+  }
+  // Hex-like chat_id (e.g. 5a0b1c2d3e4f5a6b)
+  if (/^[a-f0-9]{16,}$/i.test(trimmed)) {
+    return true;
+  }
+  return false;
+}
+
 const loadZaloChannelRuntime = createLazyRuntimeModule(() => import("./channel.runtime.js"));
 const zaloSetupWizard = createZaloSetupWizardProxy(
   async () => (await import("./setup-surface.js")).zaloSetupWizard,
@@ -234,7 +248,7 @@ export const zaloPlugin: ChannelPlugin<ResolvedZaloAccount, ZaloProbeResult> =
         normalizeTarget: normalizeZaloMessagingTarget,
         resolveOutboundSessionRoute: (params) => resolveZaloOutboundSessionRoute(params),
         targetResolver: {
-          looksLikeId: isNumericTargetId,
+          looksLikeId: isZaloTargetId,
           hint: "<chatId>",
         },
       },
