fix(ollama): show full thinking menu for live-discovered models without catalog entry

Pandah97 · Pandah97 · commit d63255741163 · 2026-06-19T17:49:21.000+08:00
When an Ollama model is discovered at runtime (not in the static config catalog), its reasoning flag is undefined. The provider policy returned the non-reasoning thinking profile (only off) when reasoning was not explicitly true, causing Telegram /think to show only default, off even though /think <level> worked. Fix: treat reasoning: undefined as reasoning-capable, since live- discovered models that report thinking capability should show the full thinking level menu. Models with explicit reasoning: false in the catalog are unaffected. Fixes #93835
diff --git a/extensions/ollama/provider-policy-api.test.ts b/extensions/ollama/provider-policy-api.test.ts
@@ -61,13 +61,17 @@ describe("ollama provider policy public artifact", () => {
   });
 
   it("exposes max thinking for reasoning-capable models without full plugin activation", () => {
-    expect(resolveThinkingProfile({ reasoning: true })).toEqual({
+    const reasoningProfile = {
       levels: [{ id: "off" }, { id: "low" }, { id: "medium" }, { id: "high" }, { id: "max" }],
       defaultLevel: "off",
-    });
+    };
+    expect(resolveThinkingProfile({ reasoning: true })).toEqual(reasoningProfile);
     expect(resolveThinkingProfile({ reasoning: false })).toEqual({
       levels: [{ id: "off" }],
       defaultLevel: "off",
     });
+    // Live-discovered models without catalog entry default to capable.
+    expect(resolveThinkingProfile({})).toEqual(reasoningProfile);
+    expect(resolveThinkingProfile({ reasoning: undefined })).toEqual(reasoningProfile);
   });
 });
diff --git a/extensions/ollama/provider-policy-api.ts b/extensions/ollama/provider-policy-api.ts
@@ -56,5 +56,10 @@ export function resolveThinkingProfile({
 }: {
   reasoning?: boolean;
 }): ProviderThinkingProfile {
-  return reasoning ? OLLAMA_REASONING_THINKING_PROFILE : OLLAMA_NON_REASONING_THINKING_PROFILE;
+  // reasoning=true  -> known reasoning model, show full thinking menu
+  // reasoning=false -> known non-reasoning model, show only "off"
+  // reasoning=undefined -> live-discovered / no catalog entry, assume capable
+  return reasoning !== false
+    ? OLLAMA_REASONING_THINKING_PROFILE
+    : OLLAMA_NON_REASONING_THINKING_PROFILE;
 }
