test(config): focus prototype restore regression

steipete · steipete · commit d5700c0185d7 · 2026-07-03T11:24:36.000+01:00
diff --git a/src/config/redact-snapshot.restore.test.ts b/src/config/redact-snapshot.restore.test.ts
@@ -100,6 +100,16 @@ describe("restoreRedactedValues", () => {
     expect(restoreRedactedValues_orig(incoming, original).ok).toBe(false);
   });
 
+  it.each(["toString", "constructor", "valueOf", "hasOwnProperty"])(
+    "rejects inherited %s values when the original key is missing",
+    (key) => {
+      const hints = { [key]: { sensitive: true } };
+      const result = restoreRedactedValues_orig({ [key]: REDACTED_SENTINEL }, {}, hints);
+
+      expect(result.ok).toBe(false);
+    },
+  );
+
   it("rejects invalid restore inputs", () => {
     const invalidInputs = [null, undefined, "token-value"] as const;
     for (const input of invalidInputs) {
diff --git a/src/config/redact-snapshot.test.ts b/src/config/redact-snapshot.test.ts
@@ -3,11 +3,7 @@ import JSON5 from "json5";
 import { describe, expect, it } from "vitest";
 import { redactSnapshotTestHints as mainSchemaHints } from "../../test/helpers/config/redact-snapshot-test-hints.js";
 import { materializeRuntimeConfig } from "./materialize.js";
-import {
-  REDACTED_SENTINEL,
-  redactConfigSnapshot,
-  restoreRedactedValues as restoreRedactedRaw,
-} from "./redact-snapshot.js";
+import { REDACTED_SENTINEL, redactConfigSnapshot } from "./redact-snapshot.js";
 import {
   makeSnapshot,
   restoreRedactedValues,
@@ -1382,15 +1378,4 @@ describe("redactConfigSnapshot", () => {
     );
     expect(restored.browser.profiles.local.cdpUrl).toBe("ws://localhost:9222");
   });
-
-  it("rejects prototype-named missing keys instead of returning functions", () => {
-    const PROTOTYPE_KEYS = ["toString", "constructor", "valueOf", "hasOwnProperty"];
-    for (const key of PROTOTYPE_KEYS) {
-      const redacted = { [key]: REDACTED_SENTINEL };
-      const original = {};
-      const hints = { [key]: { sensitive: true, label: "test" } };
-      const result = restoreRedactedRaw(redacted, original, hints);
-      expect(result.ok).toBe(false);
-    }
-  });
 });
