fix(tlon): keep fragment image URLs as media blocks

JasmineZhangHM · JasmineZhangHM · commit d3e9f4d7ed39 · 2026-07-12T09:42:41.000+08:00
diff --git a/extensions/tlon/src/urbit/send.test.ts b/extensions/tlon/src/urbit/send.test.ts
@@ -1,4 +1,6 @@
 import { afterEach, describe, expect, it, vi } from "vitest";
+import { buildMediaStory } from "./send.js";
+import { createImageBlock } from "./story.js";
 
 vi.mock("@urbit/aura", () => ({
   scot: vi.fn(() => "mocked-ud"),
@@ -7,6 +9,30 @@ vi.mock("@urbit/aura", () => ({
   },
 }));
 
+describe("buildMediaStory", () => {
+  it("treats image URLs with fragments as image blocks", () => {
+    expect(buildMediaStory("caption", "https://cdn.example/image.png#preview")).toEqual([
+      { inline: ["caption"] },
+      createImageBlock("https://cdn.example/image.png#preview", ""),
+    ]);
+  });
+
+  it("keeps non-image fragment URLs as links", () => {
+    expect(buildMediaStory(undefined, "https://cdn.example/page#preview")).toEqual([
+      {
+        inline: [
+          {
+            link: {
+              href: "https://cdn.example/page#preview",
+              content: "https://cdn.example/page#preview",
+            },
+          },
+        ],
+      },
+    ]);
+  });
+});
+
 describe("sendDm", () => {
   afterEach(() => {
     vi.restoreAllMocks();
diff --git a/extensions/tlon/src/urbit/story.ts b/extensions/tlon/src/urbit/story.ts
@@ -180,7 +180,7 @@ export function createImageBlock(
  * Check if URL looks like an image
  */
 export function isImageUrl(url: string): boolean {
-  const imageExtensions = /\.(jpg|jpeg|png|gif|webp|svg|bmp|ico)(\?.*)?$/i;
+  const imageExtensions = /\.(jpg|jpeg|png|gif|webp|svg|bmp|ico)(?:\?.*)?(?:#.*)?$/i;
   return imageExtensions.test(url);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ export function createImageBlock(`
`180`	`180`	`* Check if URL looks like an image`
`181`	`181`	`*/`
`182`	`182`	`export function isImageUrl(url: string): boolean {`
`183`		`- const imageExtensions = /\.(jpg\|jpeg\|png\|gif\|webp\|svg\|bmp\|ico)(\?.*)?$/i;`
	`183`	`+ const imageExtensions = /\.(jpg\|jpeg\|png\|gif\|webp\|svg\|bmp\|ico)(?:\?.)?(?:#.)?$/i;`
`184`	`184`	`return imageExtensions.test(url);`
`185`	`185`	`}`
`186`	`186`