test(codex): cover managed generated image media

sjf · sjf · commit d23ed819a681 · 2026-07-08T19:59:18.000-07:00
diff --git a/extensions/codex/src/app-server/run-attempt.test.ts b/extensions/codex/src/app-server/run-attempt.test.ts
@@ -144,6 +144,8 @@ const DISABLED_CODEX_WEB_SEARCH_THREAD_CONFIG_FINGERPRINT = JSON.stringify({
   "features.standalone_web_search": false,
   web_search: "disabled",
 });
+const TINY_PNG_BASE64 =
+  "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO+/p9sAAAAASUVORK5CYII=";
 
 async function writeExistingBinding(
   sessionFile: string,
@@ -3806,14 +3808,12 @@ describe("runCodexAppServerAttempt", () => {
       path.join(tempDir, "session.jsonl"),
       path.join(tempDir, "workspace"),
     );
-    const pngBase64 =
-      "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO+/p9sAAAAASUVORK5CYII=";
     params.model = createCodexTestModel("codex", ["text", "image"]);
     params.images = [
       {
         type: "image",
         mimeType: "image/png",
-        data: pngBase64,
+        data: TINY_PNG_BASE64,
       },
     ];
 
@@ -3828,7 +3828,7 @@ describe("runCodexAppServerAttempt", () => {
       | undefined;
     expect(turnStartParams?.input).toEqual([
       { type: "text", text: "hello", text_elements: [] },
-      { type: "image", url: `data:image/png;base64,${pngBase64}` },
+      { type: "image", url: `data:image/png;base64,${TINY_PNG_BASE64}` },
     ]);
   });
 
@@ -3965,12 +3965,14 @@ describe("runCodexAppServerAttempt", () => {
     expect(result.timedOut).toBe(false);
   });
 
-  it("surfaces Codex-native image generation saved paths as reply media", async () => {
+  it("persists Codex-native image results as gateway-managed reply media", async () => {
     const harness = createStartedThreadHarness();
     const params = createParams(
       path.join(tempDir, "session.jsonl"),
       path.join(tempDir, "workspace"),
     );
+    const savedPath = "/tmp/codex-home/generated_images/session-1/ig_123.png";
+    vi.stubEnv("OPENCLAW_STATE_DIR", path.join(tempDir, "state"));
 
     const run = runCodexAppServerAttempt(params);
     await harness.waitForMethod("turn/start");
@@ -3988,17 +3990,24 @@ describe("runCodexAppServerAttempt", () => {
               id: "ig_123",
               status: "completed",
               revisedPrompt: "A tiny blue square",
-              result: "Zm9v",
-              savedPath: "/tmp/codex-home/generated_images/session-1/ig_123.png",
+              result: TINY_PNG_BASE64,
+              savedPath,
             },
           ],
         },
       },
     });
 
     const result = await run;
+    const mediaUrl = result.toolMediaUrls?.[0];
+
     expect(result.assistantTexts).toEqual([]);
-    expect(result.toolMediaUrls).toEqual(["/tmp/codex-home/generated_images/session-1/ig_123.png"]);
+    expect(result.toolMediaUrls).toHaveLength(1);
+    expect(mediaUrl).not.toBe(savedPath);
+    expect(mediaUrl).toContain(`${path.sep}media${path.sep}tool-image-generation${path.sep}`);
+    await expect(fs.readFile(mediaUrl ?? "")).resolves.toEqual(
+      Buffer.from(TINY_PNG_BASE64, "base64"),
+    );
   });
 
   it("does not complete on unscoped turn/completed notifications", async () => {
