fix: re-throw non-429 errors to preserve onStartError logging

gumclaw · gumclaw · commit cf6192ba04f9 · 2026-03-23T18:08:39.000-04:00
Address review feedback: the catch block was silently swallowing all
errors, not just 429s. Non-rate-limit errors should propagate to the
pipeline's onStartError handler for logging via logTypingFailure.
diff --git a/extensions/msteams/src/reply-dispatcher.ts b/extensions/msteams/src/reply-dispatcher.ts
@@ -92,6 +92,8 @@ export function createMSTeamsReplyDispatcher(params: {
       if (errStr.includes("429") || errStr.includes("quota exceeded")) {
         typingSuppressedUntil = Date.now() + TYPING_BACKOFF_MS;
         params.log.debug?.(`msteams typing suppressed for ${TYPING_BACKOFF_MS}ms after 429`);
+      } else {
+        throw err;
       }
     }
   };

Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,8 @@ export function createMSTeamsReplyDispatcher(params: {`
`92`	`92`	`if (errStr.includes("429") \|\| errStr.includes("quota exceeded")) {`
`93`	`93`	`typingSuppressedUntil = Date.now() + TYPING_BACKOFF_MS;`
`94`	`94`	params.log.debug?.(`msteams typing suppressed for ${TYPING_BACKOFF_MS}ms after 429`);
	`95`	`+ } else {`
	`96`	`+ throw err;`
`95`	`97`	`}`
`96`	`98`	`}`
`97`	`99`	`};`