test(agents): tighten process label truncation coverage

steipete · steipete · commit cecd014b5135 · 2026-07-09T04:22:50.000+01:00
diff --git a/src/agents/bash-process-references.test.ts b/src/agents/bash-process-references.test.ts
@@ -4,31 +4,8 @@ import { addSession, deleteSession } from "./bash-process-registry.js";
 import { createProcessSessionFixture } from "./bash-process-registry.test-helpers.js";
 
 describe("bash-process-references truncation", () => {
-  it("keeps surrogate pairs intact when truncating session names", () => {
-    const command = `echo ${"😀".repeat(200)}`;
-    addSession(
-      createProcessSessionFixture({
-        id: "emoji-proc",
-        command,
-        backgrounded: true,
-        startedAt: 1,
-      }),
-    );
-
-    try {
-      const [reference] = listActiveProcessSessionReferences({
-        scopeKey: undefined,
-      });
-      expect(reference).toBeUndefined();
-      const scoped = listActiveProcessSessionReferences({ scopeKey: "scope-a", now: 2 });
-      expect(scoped).toEqual([]);
-    } finally {
-      deleteSession("emoji-proc");
-    }
-  });
-
-  it("keeps surrogate pairs intact for scoped background session labels", () => {
-    const command = `python ${"😀".repeat(200)}`;
+  it("keeps scoped session labels valid when the limit bisects an emoji", () => {
+    const command = `${"a".repeat(136)}😀xyz`;
     const session = createProcessSessionFixture({
       id: "emoji-proc-scoped",
       command,
@@ -40,8 +17,7 @@ describe("bash-process-references truncation", () => {
 
     try {
       const [reference] = listActiveProcessSessionReferences({ scopeKey: "scope-a", now: 2 });
-      expect(reference?.name).not.toContain("�");
-      expect(reference?.name.length).toBeLessThanOrEqual(140);
+      expect(reference?.name).toBe(`${"a".repeat(136)}...`);
     } finally {
       deleteSession("emoji-proc-scoped");
     }
diff --git a/src/agents/bash-process-references.ts b/src/agents/bash-process-references.ts
@@ -1,9 +1,9 @@
-import { truncateUtf16Safe } from "../utils.js";
 /**
  * Compact references for active background bash sessions.
  * These references are surfaced in agent context so follow-up turns can
  * reconnect to prior long-running work.
  */
+import { truncateUtf16Safe } from "../utils.js";
 import { listRunningSessions } from "./bash-process-registry.js";
 import { deriveSessionName } from "./bash-tools.shared.js";
 
diff --git a/src/agents/tools/web-fetch-utils.test.ts b/src/agents/tools/web-fetch-utils.test.ts
@@ -22,6 +22,7 @@ describe("web-fetch-utils htmlToMarkdown entity decoding", () => {
   });
 
   it("decodes &amp; last so an escaped entity is not double-decoded", () => {
+    // "&amp;#39;" is the correct HTML encoding of the literal text "&#39;" and must survive intact.
     expect(htmlToMarkdown(`<p>Tom &amp;#39;s pub</p>`).text).toBe("Tom &#39;s pub");
   });
 
@@ -30,8 +31,12 @@ describe("web-fetch-utils htmlToMarkdown entity decoding", () => {
   });
 
   it("preserves the prior contract: uppercase named entities decode, malformed numeric stays literal", () => {
+    // web_fetch historically matched named entities case-insensitively, so
+    // uppercase forms must keep decoding rather than leaking through as text.
     expect(htmlToMarkdown(`<p>a &AMP; b</p>`).text).toBe("a & b");
     expect(htmlToMarkdown(`<p>x &QUOT;y&QUOT;</p>`).text).toBe('x "y"');
+    // A malformed numeric reference is not an entity and must survive as text,
+    // not be consumed by a lenient parseInt (e.g. "&#39x;" must not become "'").
     expect(htmlToMarkdown(`<p>&#39x; end</p>`).text).toBe("&#39x; end");
   });
 
@@ -43,9 +48,4 @@ describe("web-fetch-utils htmlToMarkdown entity decoding", () => {
     expect(result.text).toBe(prefix);
     expect(result.text).not.toContain(String.fromCharCode(0xd83d));
   });
-
-  it("truncates extracted text without splitting surrogate pairs", () => {
-    expect(truncateText("😀abc", 1)).toEqual({ text: "", truncated: true });
-    expect(truncateText("😀😀x", 3)).toEqual({ text: "😀", truncated: true });
-  });
 });
